Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add L0 forward policy to support remote load #36189

Merged

Conversation

congqixia
Copy link
Contributor

Related to #35303

This PR add a param item to support change l0 forward behavior from bf filtering and forward to remote load.

Related to milvus-io#35303

This PR add a param item to support change l0 forward behavior from bf
filtering and forward to remote load.

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. approved labels Sep 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Sep 11, 2024
Copy link
Contributor

mergify bot commented Sep 11, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 48.05195% with 40 lines in your changes missing coverage. Please review.

Project coverage is 72.37%. Comparing base (e7ea1d7) to head (cbb665d).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...l/querynodev2/delegator/delegator_delta_forward.go 40.62% 37 Missing and 1 partial ⚠️
internal/querynodev2/delegator/delegator_data.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36189      +/-   ##
==========================================
- Coverage   81.40%   72.37%   -9.04%     
==========================================
  Files        1274     1275       +1     
  Lines      151739   151797      +58     
==========================================
- Hits       123522   109856   -13666     
- Misses      23316    37034   +13718     
- Partials     4901     4907       +6     
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 98.28% <100.00%> (+<0.01%) ⬆️
internal/querynodev2/delegator/delegator_data.go 85.80% <66.66%> (-0.18%) ⬇️
...l/querynodev2/delegator/delegator_delta_forward.go 40.62% <40.62%> (ø)

... and 252 files with indirect coverage changes

@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 11dbe1e into milvus-io:master Sep 12, 2024
14 of 16 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Sep 12, 2024
Related to milvus-io#35303

This PR add a param item to support change l0 forward behavior from bf
filtering and forward to remote load.

---------

Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Sep 12, 2024
…36208)

Cherry-pick from master
pr: #36189
Related to #35303

This PR add a param item to support change l0 forward behavior from bf
filtering and forward to remote load.

---------

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia deleted the enhance/add_l0_forward_policy branch September 13, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants