Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: improve log encoding performance on proxy nodes #36123

Merged
merged 4 commits into from
Sep 11, 2024

fixing data race

333e2ef
Select commit
Loading
Failed to load commit list.
Merged

enhance: improve log encoding performance on proxy nodes #36123

fixing data race
333e2ef
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 11, 2024 in 0s

84.87% (target 77.00%)

View this Pull Request on Codecov

84.87% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 85.71429% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.87%. Comparing base (7b21032) to head (333e2ef).
Report is 57 commits behind head on master.

Files with missing lines Patch % Lines
pkg/log/lazy_with.go 82.60% 4 Missing ⚠️
internal/proxy/task_search.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36123      +/-   ##
==========================================
+ Coverage   81.59%   84.87%   +3.27%     
==========================================
  Files        1266      990     -276     
  Lines      150648   126343   -24305     
==========================================
- Hits       122924   107229   -15695     
+ Misses      22853    14202    -8651     
- Partials     4871     4912      +41     
Files with missing lines Coverage Δ
internal/datanode/compaction/merge_sort.go 72.83% <ø> (ø)
internal/datanode/compaction/segment_writer.go 79.74% <ø> (-0.72%) ⬇️
internal/proxy/impl.go 85.87% <100.00%> (-0.03%) ⬇️
pkg/log/global.go 100.00% <100.00%> (ø)
pkg/log/mlogger.go 100.00% <100.00%> (ø)
pkg/log/zap_text_encoder.go 85.41% <100.00%> (ø)
internal/proxy/task_search.go 77.41% <0.00%> (+0.46%) ⬆️
pkg/log/lazy_with.go 82.60% <82.60%> (ø)

... and 359 files with indirect coverage changes