-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: improve log encoding performance on proxy nodes #36123
enhance: improve log encoding performance on proxy nodes #36123
Conversation
Signed-off-by: Ted Xu <[email protected]>
Benchmark results using default JSON library:
Results of using json-iterator and
|
Signed-off-by: Ted Xu <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #36123 +/- ##
==========================================
+ Coverage 81.59% 84.87% +3.27%
==========================================
Files 1266 990 -276
Lines 150648 126343 -24305
==========================================
- Hits 122924 107229 -15695
+ Misses 22853 14202 -8651
- Partials 4871 4912 +41
|
Signed-off-by: Ted Xu <[email protected]>
I'm directing all
|
Signed-off-by: Ted Xu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, tedxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…6123) See milvus-io#36122 This PR is designed to enhance log performance through two improvements: 1. Optimize JSON encoding by switching JSON serializer to `json-iterator`. 2. Adding support of lazy initialization `WithLazy`. --------- Signed-off-by: Ted Xu <[email protected]>
See #36122
This PR is designed to enhance log performance through two improvements:
json-iterator
.WithLazy
.