Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: to fill default value when nullable and default value are both enable #36030

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

smellthemoon
Copy link
Contributor

@smellthemoon smellthemoon changed the title fix: to filldefault value when nullable and default value are both enable fix: to fill default value when nullable and default value are both enable Sep 6, 2024
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 6, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug ci-passed labels Sep 6, 2024
@mergify mergify bot removed the ci-passed label Sep 11, 2024
@smellthemoon
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.71%. Comparing base (329fb42) to head (679ad1d).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/validate_util.go 66.66% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36030      +/-   ##
==========================================
+ Coverage   82.46%   84.71%   +2.24%     
==========================================
  Files        1271      994     -277     
  Lines      149930   126996   -22934     
==========================================
- Hits       123644   107579   -16065     
+ Misses      21340    14470    -6870     
- Partials     4946     4947       +1     
Files with missing lines Coverage Δ
internal/proxy/validate_util.go 90.58% <66.66%> (-0.72%) ⬇️

... and 305 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Sep 14, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Sep 18, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Sep 18, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e84c4f2 into milvus-io:master Sep 19, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants