-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: to fill default value when nullable and default value are both enable #36030
Conversation
bb5304b
to
1132132
Compare
rerun ut |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #36030 +/- ##
==========================================
+ Coverage 82.46% 84.71% +2.24%
==========================================
Files 1271 994 -277
Lines 149930 126996 -22934
==========================================
- Hits 123644 107579 -16065
+ Misses 21340 14470 -6870
- Partials 4946 4947 +1
|
…both Signed-off-by: lixinguo <[email protected]>
1132132
to
679ad1d
Compare
@smellthemoon E2e jenkins job failed, comment |
1 similar comment
@smellthemoon E2e jenkins job failed, comment |
/run-cpu-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, smellthemoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#36003