fix: to filldefault value when nullable and default value are enable …

…both Signed-off-by: lixinguo <[email protected]>
milvus-io · Sep 6, 2024 · bb5304b · bb5304b
1 parent 11325d9
commit bb5304b
Show file tree

Hide file tree

Showing 2 changed files with 350 additions and 11 deletions.
diff --git a/internal/proxy/validate_util.go b/internal/proxy/validate_util.go
@@ -391,7 +391,9 @@ func (v *validateUtil) fillWithDefaultValue(field *schemapb.FieldData, fieldSche
 				return err
 			}
 
-			if !fieldSchema.GetNullable() {
+			if fieldSchema.GetNullable() {
+				field.ValidData = make([]bool, numRows)
+			} else {
 				field.ValidData = []bool{}
 			}
 
@@ -406,7 +408,9 @@ func (v *validateUtil) fillWithDefaultValue(field *schemapb.FieldData, fieldSche
 				return err
 			}
 
-			if !fieldSchema.GetNullable() {
+			if fieldSchema.GetNullable() {
+				field.ValidData = make([]bool, numRows)
+			} else {
 				field.ValidData = []bool{}
 			}
 
@@ -420,7 +424,9 @@ func (v *validateUtil) fillWithDefaultValue(field *schemapb.FieldData, fieldSche
 			if err != nil {
 				return err
 			}
-			if !fieldSchema.GetNullable() {
+			if fieldSchema.GetNullable() {
+				field.ValidData = make([]bool, numRows)
+			} else {
 				field.ValidData = []bool{}
 			}
 
@@ -434,8 +440,9 @@ func (v *validateUtil) fillWithDefaultValue(field *schemapb.FieldData, fieldSche
 			if err != nil {
 				return err
 			}
-
-			if !fieldSchema.GetNullable() {
+			if fieldSchema.GetNullable() {
+				field.ValidData = make([]bool, numRows)
+			} else {
 				field.ValidData = []bool{}
 			}
 
@@ -449,8 +456,9 @@ func (v *validateUtil) fillWithDefaultValue(field *schemapb.FieldData, fieldSche
 			if err != nil {
 				return err
 			}
-
-			if !fieldSchema.GetNullable() {
+			if fieldSchema.GetNullable() {
+				field.ValidData = make([]bool, numRows)
+			} else {
 				field.ValidData = []bool{}
 			}
 
@@ -464,8 +472,9 @@ func (v *validateUtil) fillWithDefaultValue(field *schemapb.FieldData, fieldSche
 			if err != nil {
 				return err
 			}
-
-			if !fieldSchema.GetNullable() {
+			if fieldSchema.GetNullable() {
+				field.ValidData = make([]bool, numRows)
+			} else {
 				field.ValidData = []bool{}
 			}
 
@@ -484,8 +493,9 @@ func (v *validateUtil) fillWithDefaultValue(field *schemapb.FieldData, fieldSche
 			if err != nil {
 				return err
 			}
-
-			if !fieldSchema.GetNullable() {
+			if fieldSchema.GetNullable() {
+				field.ValidData = make([]bool, numRows)
+			} else {
 				field.ValidData = []bool{}
 			}