Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Support memory mode chunk cache (#35347) #35836

Merged
merged 15 commits into from
Oct 18, 2024

Conversation

bigsheeper
Copy link
Contributor

Chunk cache supports loading raw vectors into memory.

issue: #35273

pr: #35347

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Aug 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 29, 2024
Copy link
Contributor

mergify bot commented Aug 29, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Aug 30, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: bigsheeper <[email protected]>
@mergify mergify bot added the ci-passed label Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 76.19048% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.76%. Comparing base (22838a8) to head (ed795c7).
Report is 3 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/querynodev2/segments/segment.go 0.00% 8 Missing ⚠️
internal/core/src/segcore/segment_c.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35836      +/-   ##
==========================================
- Coverage   80.60%   79.76%   -0.85%     
==========================================
  Files        1065     1065              
  Lines      164516   164540      +24     
==========================================
- Hits       132615   131249    -1366     
- Misses      27556    28937    +1381     
- Partials     4345     4354       +9     
Files with missing lines Coverage Δ
internal/core/src/segcore/SegmentSealed.h 100.00% <ø> (ø)
internal/core/src/segcore/SegmentSealedImpl.cpp 84.28% <100.00%> (+0.04%) ⬆️
internal/core/src/segcore/SegmentSealedImpl.h 80.00% <ø> (ø)
internal/core/src/storage/ChunkCache.cpp 86.36% <100.00%> (+0.99%) ⬆️
internal/core/src/storage/ChunkCache.h 0.00% <ø> (-100.00%) ⬇️
internal/querynodev2/server.go 77.71% <100.00%> (+0.12%) ⬆️
pkg/util/paramtable/component_param.go 98.33% <100.00%> (+<0.01%) ⬆️
internal/core/src/segcore/segment_c.cpp 65.67% <0.00%> (ø)
internal/querynodev2/segments/segment.go 66.80% <0.00%> (-0.22%) ⬇️

... and 90 files with indirect coverage changes

Signed-off-by: bigsheeper <[email protected]>
@mergify mergify bot removed the ci-passed label Sep 8, 2024
Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
@bigsheeper
Copy link
Contributor Author

/hold

@bigsheeper
Copy link
Contributor Author

/unhold

@czs007
Copy link
Collaborator

czs007 commented Sep 17, 2024

e2e is not triggered

@mergify mergify bot added the ci-passed label Sep 18, 2024
Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
@mergify mergify bot removed the ci-passed label Oct 14, 2024
Signed-off-by: bigsheeper <[email protected]>
@mergify mergify bot added the ci-passed label Oct 14, 2024
@mergify mergify bot added ci-passed and removed ci-passed labels Oct 18, 2024
@czs007
Copy link
Collaborator

czs007 commented Oct 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 8923936 into milvus-io:2.4 Oct 18, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants