Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Support memory mode chunk cache #35347

Merged
merged 11 commits into from
Aug 25, 2024

Conversation

bigsheeper
Copy link
Contributor

Chunk cache supports loading raw vectors into memory.

issue: #35273

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Aug 7, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 20 lines in your changes missing coverage. Please review.

Project coverage is 81.35%. Comparing base (9dc1311) to head (aa8837b).
Report is 4 commits behind head on master.

Files Patch % Lines
internal/querynodev2/segments/segment.go 0.00% 7 Missing ⚠️
internal/core/src/segcore/SegmentSealedImpl.cpp 0.00% 6 Missing ⚠️
internal/core/src/storage/ChunkCache.cpp 61.53% 5 Missing ⚠️
internal/core/src/segcore/segment_c.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35347      +/-   ##
==========================================
+ Coverage   81.34%   81.35%   +0.01%     
==========================================
  Files        1237     1237              
  Lines      147652   147665      +13     
==========================================
+ Hits       120105   120133      +28     
+ Misses      22792    22771      -21     
- Partials     4755     4761       +6     
Files Coverage Δ
internal/core/src/segcore/SegmentSealed.h 100.00% <ø> (ø)
internal/core/src/segcore/SegmentSealedImpl.h 56.52% <ø> (ø)
internal/core/src/storage/ChunkCache.h 100.00% <ø> (ø)
internal/core/src/segcore/segment_c.cpp 70.74% <0.00%> (ø)
internal/core/src/storage/ChunkCache.cpp 59.30% <61.53%> (-0.20%) ⬇️
internal/core/src/segcore/SegmentSealedImpl.cpp 76.23% <0.00%> (-0.26%) ⬇️
internal/querynodev2/segments/segment.go 71.29% <0.00%> (-0.25%) ⬇️

... and 25 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Aug 7, 2024
@bigsheeper
Copy link
Contributor Author

/hold

Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
@mergify mergify bot removed the ci-passed label Aug 21, 2024
@bigsheeper
Copy link
Contributor Author

/unhold

Copy link
Contributor

mergify bot commented Aug 21, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Aug 23, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Aug 23, 2024
@czs007
Copy link
Collaborator

czs007 commented Aug 25, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f2b83d3 into milvus-io:master Aug 25, 2024
15 of 16 checks passed
bigsheeper added a commit to bigsheeper/milvus that referenced this pull request Aug 29, 2024
sre-ci-robot pushed a commit that referenced this pull request Oct 18, 2024
Chunk cache supports loading raw vectors into memory.

issue: #35273

pr: #35347

---------

Signed-off-by: bigsheeper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants