Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Refresh proxy cache after restore rbac meta #35636

Merged
merged 2 commits into from
Aug 22, 2024

fix ut

5c7db5f
Select commit
Loading
Failed to load commit list.
Merged

enhance: Refresh proxy cache after restore rbac meta #35636

fix ut
5c7db5f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 22, 2024 in 0s

80.21% (target 77.00%)

View this Pull Request on Codecov

80.21% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.21%. Comparing base (e2542a1) to head (5c7db5f).
Report is 4 commits behind head on 2.4.

Files Patch % Lines
internal/rootcoord/root_coord.go 85.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35636      +/-   ##
==========================================
+ Coverage   71.88%   80.21%   +8.33%     
==========================================
  Files        1056     1056              
  Lines      138493   138589      +96     
==========================================
+ Hits        99560   111176   +11616     
+ Misses      34697    23172   -11525     
- Partials     4236     4241       +5     
Files Coverage Δ
internal/metastore/kv/rootcoord/kv_catalog.go 87.50% <100.00%> (-0.22%) ⬇️
internal/rootcoord/root_coord.go 91.67% <85.00%> (-0.09%) ⬇️

... and 258 files with indirect coverage changes