Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Refresh proxy cache after restore rbac meta #35636

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #35443
pr: #35635

@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/M Denotes a PR that changes 30-99 lines. labels Aug 22, 2024
@sre-ci-robot sre-ci-robot requested review from cydrain and czs007 August 22, 2024 03:49
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 22, 2024
Signed-off-by: Wei Liu <[email protected]>
@mergify mergify bot added the ci-passed label Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.21%. Comparing base (e2542a1) to head (5c7db5f).
Report is 5 commits behind head on 2.4.

Files Patch % Lines
internal/rootcoord/root_coord.go 85.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35636      +/-   ##
==========================================
+ Coverage   71.88%   80.21%   +8.33%     
==========================================
  Files        1056     1056              
  Lines      138493   138589      +96     
==========================================
+ Hits        99560   111176   +11616     
+ Misses      34697    23172   -11525     
- Partials     4236     4241       +5     
Files Coverage Δ
internal/metastore/kv/rootcoord/kv_catalog.go 87.50% <100.00%> (-0.22%) ⬇️
internal/rootcoord/root_coord.go 91.67% <85.00%> (-0.09%) ⬇️

... and 258 files with indirect coverage changes

@SimFG
Copy link
Contributor

SimFG commented Aug 22, 2024

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 421a00b into milvus-io:2.4 Aug 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/M Denotes a PR that changes 30-99 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants