Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Refresh proxy cache after restore rbac meta #35635

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #35443

@sre-ci-robot sre-ci-robot added area/test sig/testing size/M Denotes a PR that changes 30-99 lines. test/integration integration test labels Aug 22, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 22, 2024
Signed-off-by: Wei Liu <[email protected]>
@mergify mergify bot added the ci-passed label Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.39%. Comparing base (c992a61) to head (9417f79).
Report is 5 commits behind head on master.

Files Patch % Lines
internal/rootcoord/root_coord.go 85.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35635      +/-   ##
==========================================
- Coverage   72.44%   72.39%   -0.06%     
==========================================
  Files        1236     1236              
  Lines      147469   147589     +120     
==========================================
+ Hits       106839   106847       +8     
- Misses      35872    35977     +105     
- Partials     4758     4765       +7     
Files Coverage Δ
internal/metastore/kv/rootcoord/kv_catalog.go 87.45% <100.00%> (-0.22%) ⬇️
internal/rootcoord/root_coord.go 91.39% <85.00%> (-0.09%) ⬇️

... and 54 files with indirect coverage changes

@SimFG
Copy link
Contributor

SimFG commented Aug 22, 2024

/lgtm

@SimFG
Copy link
Contributor

SimFG commented Aug 22, 2024

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 5c245d5 into milvus-io:master Aug 22, 2024
14 of 16 checks passed
sre-ci-robot pushed a commit that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/M Denotes a PR that changes 30-99 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants