Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Update protobuf-go to protobuf-go v2 (#34394) #35555

Merged
merged 1 commit into from
Aug 21, 2024
Merged

enhance: Update protobuf-go to protobuf-go v2 (#34394) #35555

merged 1 commit into from
Aug 21, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #34252
pr: #34394 #35072 #35084

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/compilation area/dependency Pull requests that update a dependency file area/test sig/testing test/integration integration test labels Aug 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 19, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 19, 2024

@weiliu1031 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Aug 19, 2024
@weiliu1031 weiliu1031 force-pushed the cp_protobuf_v2 branch 2 times, most recently from a4676c3 to f7b5039 Compare August 19, 2024 09:17
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Aug 19, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 19, 2024

@weiliu1031 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Aug 19, 2024
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Aug 19, 2024
@mergify mergify bot added the ci-passed label Aug 21, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.84848% with 30 lines in your changes missing coverage. Please review.

Project coverage is 81.14%. Comparing base (4bf4cba) to head (81b04ed).
Report is 3 commits behind head on 2.4.

Files Patch % Lines
pkg/util/funcutil/policy.go 40.00% 18 Missing and 3 partials ⚠️
pkg/mq/msgstream/msg_for_index.go 58.33% 5 Missing ⚠️
pkg/mq/msgstream/msg.go 94.59% 2 Missing ⚠️
internal/datacoord/server.go 0.00% 0 Missing and 1 partial ⚠️
internal/querynodev2/segments/segment.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35555      +/-   ##
==========================================
+ Coverage   71.88%   81.14%   +9.26%     
==========================================
  Files        1056     1056              
  Lines      138448   138493      +45     
==========================================
+ Hits        99521   112385   +12864     
+ Misses      34689    21868   -12821     
- Partials     4238     4240       +2
Files Coverage Δ
internal/datacoord/analyze_meta.go 100.00% <ø> (ø)
internal/datacoord/channel.go 82.11% <ø> (ø)
internal/datacoord/channel_checker.go 95.83% <ø> (ø)
internal/datacoord/channel_manager_v2.go 87.11% <ø> (ø)
internal/datacoord/channel_store.go 78.43% <ø> (ø)
internal/datacoord/channel_store_v2.go 81.64% <ø> (ø)
internal/datacoord/compaction_task_meta.go 84.21% <ø> (ø)
internal/datacoord/import_job.go 100.00% <ø> (ø)
internal/datacoord/import_task.go 96.49% <ø> (ø)
internal/datacoord/index_meta.go 95.64% <ø> (+0.34%) ⬆️
... and 77 more

... and 225 files with indirect coverage changes

congqixia
congqixia approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e2542a1 into milvus-io:2.4 Aug 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@aoiasd aoiasd Awaiting requested review from aoiasd

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

Assignees

@congqixia congqixia

Labels
approved area/compilation area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weiliu1031 @sre-ci-robot @congqixia