enhance: Refine protobuf dependency installation in Makefile #35072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to milvus-io#34394 Signed-off-by: Congqi Xia <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
Signed-off-by: Congqi Xia <[email protected]>
|
/lgtm |
OxalisCu
pushed a commit
to OxalisCu/milvus
that referenced
this pull request
Jul 30, 2024
…io#35072) Related to milvus-io#34394 --------- Signed-off-by: Congqi Xia <[email protected]>
|
After this PR, I'm getting a couple of errors at the top of my I think it has to do with these lines: PROTOC_GEN_GO_OUTPUT := $(shell print | $(INSTALL_PATH)/protoc-gen-go --version 2>/dev/null)
...
PROTOC_GEN_GO_GRPC_OUTPUT := $(shell print | $(INSTALL_PATH)/protoc-gen-go-grpc --version 2>/dev/null)The build still goes through, but it would be nice to clean up the errors Edit: Looks like this is a zsh/bash compatibility issue. Raised a PR to replace |
sumitd2
pushed a commit
to sumitd2/milvus
that referenced
this pull request
Aug 6, 2024
…io#35072) Related to milvus-io#34394 --------- Signed-off-by: Congqi Xia <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
weiliu1031
pushed a commit
to weiliu1031/milvus
that referenced
this pull request
Aug 19, 2024
…io#35072) Related to milvus-io#34394 --------- Signed-off-by: Congqi Xia <[email protected]>
weiliu1031
pushed a commit
to weiliu1031/milvus
that referenced
this pull request
Aug 19, 2024
…io#35072) Related to milvus-io#34394 --------- Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Aug 21, 2024
issue: #34252 pr: #34394 #35072 #35084 Signed-off-by: Wei Liu <[email protected]> Co-authored-by: Congqi Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #34394