Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Enable ReadOnly/ReadWrite/Admin Privilege Group to simplify RBAC grant progress (#35472) #35543

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #35471
pr: #35472 #35515


@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Aug 19, 2024
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Aug 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.85%. Comparing base (4a5e6bc) to head (09abd89).
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35543      +/-   ##
==========================================
+ Coverage   71.81%   71.85%   +0.03%     
==========================================
  Files        1056     1056              
  Lines      138397   138445      +48     
==========================================
+ Hits        99395    99476      +81     
+ Misses      34750    34727      -23     
+ Partials     4252     4242      -10     
Files Coverage Δ
internal/proxy/privilege_interceptor.go 81.94% <100.00%> (+5.36%) ⬆️
pkg/util/constant.go 100.00% <ø> (ø)
pkg/util/paramtable/component_param.go 98.60% <100.00%> (+<0.01%) ⬆️

... and 26 files with indirect coverage changes

@SimFG
Copy link
Contributor

SimFG commented Aug 19, 2024

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 14ec3dc into milvus-io:2.4 Aug 19, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants