Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Enable ReadOnly/ReadWrite/Admin Privilege Group to simplify RBAC grant progress #35472

Merged
merged 2 commits into from
Aug 16, 2024
Merged

enhance: Enable ReadOnly/ReadWrite/Admin Privilege Group to simplify RBAC grant progress #35472

merged 2 commits into from
Aug 16, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #35471

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/dependency Pull requests that update a dependency file labels Aug 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 14, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 14, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031 weiliu1031 force-pushed the enable_privilege_group branch 2 times, most recently from 7906bf1 to 21a4d77 Compare August 15, 2024 02:11
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 15, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Aug 15, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.27%. Comparing base (1d49358) to head (47d02e1).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35472      +/-   ##
==========================================
+ Coverage   72.41%   80.27%   +7.85%     
==========================================
  Files        1226     1218       -8     
  Lines      144651   143771     -880     
==========================================
+ Hits       104751   115406   +10655     
+ Misses      35423    23876   -11547     
- Partials     4477     4489      +12
Files Coverage Δ
internal/proxy/privilege_interceptor.go 81.94% <100.00%> (+5.36%) ⬆️
pkg/util/constant.go 93.33% <ø> (-6.67%) ⬇️
pkg/util/paramtable/component_param.go 98.51% <100.00%> (+<0.01%) ⬆️

... and 376 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 15, 2024

@weiliu1031 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. ci-passed labels Aug 15, 2024
@weiliu1031 weiliu1031 force-pushed the enable_privilege_group branch from 8ca44a7 to 9d414d8 Compare August 15, 2024 14:19
@mergify mergify bot added dco-passed DCO check passed. ci-passed and removed needs-dco DCO is missing in this pull request. labels Aug 15, 2024
@weiliu1031 weiliu1031 force-pushed the enable_privilege_group branch from 9d414d8 to 47d02e1 Compare August 16, 2024 02:24
@mergify mergify bot added ci-passed and removed ci-passed labels Aug 16, 2024
@SimFG
Copy link
Contributor

SimFG commented Aug 16, 2024

/lgtm

congqixia
congqixia approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a570567 into milvus-io:master Aug 16, 2024
12 of 13 checks passed
weiliu1031 added a commit to weiliu1031/milvus that referenced this pull request Aug 19, 2024
@weiliu1031
enhance: Enable ReadOnly/ReadWrite/Admin Privilege Group to simplify …
fdbb4eb 
…RBAC grant progress (milvus-io#35472)

issue: milvus-io#35471

---------

Signed-off-by: Wei Liu <[email protected]>
@weiliu1031 weiliu1031 mentioned this pull request Aug 19, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Aug 19, 2024
@weiliu1031
enhance: Enable ReadOnly/ReadWrite/Admin Privilege Group to simplify …
14ec3dc 
…RBAC grant progress (#35472) (#35543)

issue: #35471
pr: #35472 #35515

---------

---------

Signed-off-by: Wei Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@SimFG SimFG

Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weiliu1031 @SimFG @sre-ci-robot @congqixia