-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try to upgrade to 1.18 #18112
try to upgrade to 1.18 #18112
Conversation
@jiaoew1991 E2e jenkins job failed, comment |
@jiaoew1991 ut workflow job failed, comment |
@jiaoew1991 E2e jenkins job failed, comment |
Codecov Report
@@ Coverage Diff @@
## master #18112 +/- ##
==========================================
- Coverage 81.75% 81.68% -0.07%
==========================================
Files 472 472
Lines 75267 75260 -7
==========================================
- Hits 61533 61475 -58
- Misses 11004 11045 +41
- Partials 2730 2740 +10
|
@jiaoew1991 E2e jenkins job failed, comment |
@jiaoew1991 ut workflow job failed, comment |
Signed-off-by: Enwei Jiao <[email protected]>
looks good to me. |
@jiaoew1991 @xiaofan-luan We'll try a 100m milvus cluster stability test to check whether any performance downgradation. If everything goes well, then we can merge this pr. |
This pr only change the dockerfile to build builder image can be merged first, as ci does not use this dockerfile to build. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiaoew1991, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Enwei Jiao [email protected]
issue: #18111