Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to upgrade to 1.18 #18112

Merged
merged 1 commit into from
Jul 8, 2022
Merged

try to upgrade to 1.18 #18112

merged 1 commit into from
Jul 8, 2022

Conversation

jiaoew1991
Copy link
Contributor

Signed-off-by: Enwei Jiao [email protected]
issue: #18111

@sre-ci-robot sre-ci-robot added area/compilation area/dependency Pull requests that update a dependency file labels Jul 6, 2022
@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Jul 6, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Jul 6, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2022

@jiaoew1991 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2022

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2022

@jiaoew1991 E2e jenkins job failed, comment /run-checks can trigger the job again.

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #18112 (26dea3a) into master (d4a1e94) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18112      +/-   ##
==========================================
- Coverage   81.75%   81.68%   -0.07%     
==========================================
  Files         472      472              
  Lines       75267    75260       -7     
==========================================
- Hits        61533    61475      -58     
- Misses      11004    11045      +41     
- Partials     2730     2740      +10     
Impacted Files Coverage Δ
internal/querycoord/handoff_handler.go 79.75% <0.00%> (-4.05%) ⬇️
internal/querycoord/querynode.go 70.76% <0.00%> (-2.55%) ⬇️
internal/util/funcutil/parallel.go 43.50% <0.00%> (-1.95%) ⬇️
internal/util/grpcclient/client.go 92.50% <0.00%> (-1.88%) ⬇️
internal/proxy/segment.go 87.87% <0.00%> (-1.52%) ⬇️
internal/querycoord/query_coord.go 73.63% <0.00%> (-1.18%) ⬇️
internal/querycoord/task_scheduler.go 77.52% <0.00%> (-1.15%) ⬇️
internal/querynode/query_node.go 80.78% <0.00%> (-0.88%) ⬇️
internal/indexcoord/index_coord.go 77.95% <0.00%> (-0.88%) ⬇️
internal/datacoord/segment_manager.go 81.99% <0.00%> (-0.84%) ⬇️
... and 8 more

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2022

@jiaoew1991 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2022

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: Enwei Jiao <[email protected]>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Jul 7, 2022
@mergify mergify bot added the ci-passed label Jul 7, 2022
@xiaofan-luan
Copy link
Collaborator

looks good to me.
@LoveEachDay any concerns?

@LoveEachDay
Copy link
Contributor

looks good to me. @LoveEachDay any concerns?

@jiaoew1991 @xiaofan-luan We'll try a 100m milvus cluster stability test to check whether any performance downgradation. If everything goes well, then we can merge this pr.

@jennyli-z
Copy link
Contributor

This pr only change the dockerfile to build builder image can be merged first, as ci does not use this dockerfile to build.
After this is merged, robot will create a pr like https://github.com/milvus-io/milvus/pull/15410/files, we will not let this merge, as there's many code change to fit the 1.18 version, we can hold on that pr to do more testing.

@LoveEachDay
Copy link
Contributor

/lgtm

@xiaofan-luan
Copy link
Collaborator

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c5b5afb into milvus-io:master Jul 8, 2022
@jiaoew1991 jiaoew1991 deleted the try-1.18 branch July 20, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants