Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Upgrade Go 1.18 #18111

Closed
3 tasks done
jiaoew1991 opened this issue Jul 6, 2022 · 1 comment
Closed
3 tasks done

[Enhancement]: Upgrade Go 1.18 #18111

jiaoew1991 opened this issue Jul 6, 2022 · 1 comment
Assignees
@jiaoew1991
Labels
kind/enhancement Issues or changes related to enhancement

Comments

@jiaoew1991
Copy link
Contributor

jiaoew1991 commented Jul 6, 2022 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

Upgrade Go version from 1.16 to 1.18
Go1.18 have lots of new features https://go.dev/blog/go1.18
Using Generic can reduce lots of boilerplate code in our codebase.

As far as I know we did not upgrade to 1.18 because of the golangci-lint did not support 1.18.
They support 1.18 in these issues golangci/golangci-lint#2649 golangci/golangci-lint#2414

there are several steps to finish this issue

  • upgrade docker's Go version
  • upgrade go.mod and documents

Why is this needed?

No response

Anything else?

No response
@jiaoew1991 jiaoew1991 added the kind/enhancement Issues or changes related to enhancement label Jul 6, 2022
This was referenced Jul 6, 2022
Merged
Merged
@jiaoew1991 jiaoew1991 self-assigned this Jul 26, 2022
@jiaoew1991
Copy link
Contributor Author

upgrade finished, now we can use Go 1.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiaoew1991 jiaoew1991

Labels
kind/enhancement Issues or changes related to enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jiaoew1991