Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define min and max widths for MdTile #163

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Define min and max widths for MdTile #163

merged 1 commit into from
Sep 9, 2024

Conversation

aurorascharff
Copy link
Contributor

Describe your changes

Define min and max width for MdTile, let it flex otherwise.

Decided after discussion with designers and specification in MD design system.

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • I have added label to the PR (major, minor or patch)
  • If new component: Is story for component created in stories-folder?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is css-file added to packages/css/index.css?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Please set a versioning label of either major, minor, or patch to the pull request.

@aurorascharff aurorascharff marked this pull request as ready for review September 9, 2024 12:51
@aurorascharff aurorascharff requested a review from a team as a code owner September 9, 2024 12:51
@aurorascharff aurorascharff merged commit 9dcc83f into main Sep 9, 2024
5 checks passed
@aurorascharff aurorascharff deleted the fix-tile-width-2 branch September 9, 2024 12:57
aurorascharff added a commit that referenced this pull request Sep 9, 2024
@aurorascharff
Revert: Define min and max widths for MdTile (#163) (#164)
43395f3 
* fix: tile height must be 100% when width is 100% to fit the grid used around it

* Make the fullwidth tile optional to avoid breaking current projects' usage

* fix: width not working

* fix: max-width not set correctly

* Update

* Update

* Update

* Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaslarsson thomaslarsson thomaslarsson approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aurorascharff @thomaslarsson