Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert: Define min and max widths for MdTile (#163) #164

Merged
merged 8 commits into from
Sep 9, 2024
Merged

Revert: Define min and max widths for MdTile (#163) #164

merged 8 commits into from
Sep 9, 2024

Conversation

aurorascharff
Copy link
Contributor

@aurorascharff aurorascharff commented Sep 9, 2024 •
edited
Loading

Describe your changes

Making tiles full-width (previous PR) might cause unwanted changes in existing projects. Undo and re-think solution.
Update CSS docs as well.

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • I have added label to the PR (major, minor or patch)
  • If new component: Is story for component created in stories-folder?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is css-file added to packages/css/index.css?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Please set a versioning label of either major, minor, or patch to the pull request.

@aurorascharff aurorascharff changed the title fix: tile height must be 100% when width is 100% Make MdTile fullwidth optional to avoid changing UI of exisiting projects Sep 9, 2024
@aurorascharff aurorascharff changed the title Make MdTile fullwidth optional to avoid changing UI of exisiting projects Revert: Define min and max widths for MdTile (#163) Sep 9, 2024
@aurorascharff aurorascharff added patch and removed patch labels Sep 9, 2024
@aurorascharff aurorascharff marked this pull request as ready for review September 9, 2024 17:48
@aurorascharff aurorascharff requested a review from a team as a code owner September 9, 2024 17:48
@aurorascharff aurorascharff merged commit 43395f3 into main Sep 9, 2024
5 checks passed
@aurorascharff aurorascharff deleted the fix-tile-height branch September 9, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aurorascharff