Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_metadata kwdict flag and fix #865 #866

Closed
wants to merge 4 commits into from

Conversation

GiovanH
Copy link
Contributor

@GiovanH GiovanH commented Jul 3, 2020

You may want to edit the implementation of pseudo_kwdict? I wasn't sure what the self.extension check was designed to fix but I didn't want to cause a conflict with that behavior.

mikf added a commit that referenced this pull request Feb 17, 2021
@mikf
Copy link
Owner

mikf commented Feb 21, 2021

So Message.Metadata got removed (56a8968), which makes this PR rather superfluous.

The metadata post processor (if it should still be called that) now has a filename and event option, which allows for a better functionality than Message.Metadata and bypost ever had:

        "postprocessors": [
            {
                "name": "metadata",
                "event": "post",
                "filename": "{id}.json"
            }
        ]

It is also planned for 2.0.0 to have "event": "post" with a reasonable filename be the default for all extractors, so that --write-metadata or "postprocessors": [{"name": "metadata"}] will do the "right" thing without the need to specify any extra options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants