Regression: Patreon metadata no longer downloads if there are no files

[GiovanH]

Using configuration

{
  "extractor": {
    "base-directory": "./meta/",
    "event": "post",
    "postprocessors": [{
      "name": "metadata",
      "mode": "json"
    }]
  }
}

(with the event "post" as instructed) patreon posts that only have text content are skipped entirely as of the latest git revision.

See also #866 (comment)

Program flow goes through _pagination and _process for each post, including the skipped posts, and _process yields the correct attribute dictionary, so this doesn't seem like a problem with the patreon extractor specifically.

Edit 2: With the given configuration the "post" hook callback in job.py doesn't even seem to be firing at all? It may be that "event": "post" is actually broken. For text-only posts (and only text-only posts) [patreon][debug] Active postprocessor modules: [MetadataPP] doesn't even fire.

[GiovanH]

After... extensive testing, it seems the configuration must be

{
  "extractor": {
    "base-directory": "./meta/",
    "skip": false,
    "postprocessors": [{
      "name": "metadata",
      "event": "post",
      "mode": "json",
      "filename": "{id}_{title}_{num:>02}.json"
    }]
  }
}

The mode must be specified within the specific extractor (inheritance doesn't work) and you have to supply an explicit filename template or else it uses metadata.json and overwrites itself.

This is... probably not desired.

[mikf]

(with the event "post" as instructed) patreon posts that only have text content are skipped entirely as of the latest git revision.

"event": "post" must be specified inside the post processor settings, otherwise it uses "event": "file" by default. The comment you linked has all 3 required settings (name, event, filename) in the same post processor block and it works as promised

The mode must be specified within the specific extractor (inheritance doesn't work)

Yeah, but "mode": "json" is the default and doesn't need to be specified explicitly

you have to supply an explicit filename template

There is no default template for post files yet