feat: Add LabelCustomColor component #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
|
🚀 Deployed Storybook Preview: http://migtools-lib-ui-pr-125-preview.surge.sh ✨ |
…t-in ReactNode type Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
mturley
force-pushed
the
label-custom-color
branch
from
66f26d4 to
1e809db
Compare
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
ibolton336
reviewed
Mar 22, 2023
| const blackTextReadability = () => tinycolor.readability(bgColorObj, '#000000'); | ||
| const whiteTextReadability = () => tinycolor.readability(bgColorObj, '#FFFFFF'); | ||
| while (blackTextReadability() < 9 && whiteTextReadability() < 9) { | ||
| bgColorObj.lighten(5); |
ibolton336
reviewed
Mar 22, 2023
| } | ||
|
|
||
| const globalColorCache: Record< | ||
| string, |
|
🎉 This PR is included in version 8.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a LabelCustomColor component which attempts to render a PatternFly Label with any given hex color, adjusting colors to maintain acceptable text/background contrast.
Idea: If we have a defined set of colors for Tackle Hub, we could write unit tests here that render labels in every one of those colors and check the contrast with real a11y validators like axe.