🐛 Display tags color upon their category #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibolton336
previously requested changes
Mar 21, 2023
|
This might help :) migtools/lib-ui#125 |
gildub
changed the title
Signed-off-by: Gilles Dubreuil <[email protected]>
|
@mturley, thanks and nice work with the migtools/lib-ui wrapper. |
mturley
reviewed
Mar 28, 2023
| @@ -222,22 +223,19 @@ export const ApplicationTags: React.FC<ApplicationTagsProps> = ({ | |||
| </Text> | |||
| </TextContent> | |||
| <Flex> | |||
| {tagsInThisCategoryInThisSource | |||
| ?.sort((a, b) => a.name.localeCompare(b.name)) | |||
There was a problem hiding this comment.
@gildub why remove the sorting here?
mturley
approved these changes
Mar 28, 2023
mturley
pushed a commit
to mturley/tackle2-ui
that referenced
this pull request
Mar 31, 2023
Signed-off-by: Gilles Dubreuil <[email protected]>
mturley
added a commit
that referenced
this pull request
Mar 31, 2023
* Use LabelCustomColor from migtools/lib-ui (#745) Signed-off-by: Gilles Dubreuil <[email protected]> * ✨ Expand tag category color palette to 16 colors, add deterministic fallback colors for tag categories (#781) * Add deterministic fallback colors for tag categories Signed-off-by: Mike Turley <[email protected]> * Tweak colors, add named constants, TODO Signed-off-by: Mike Turley <[email protected]> * Use new color palette in all tag-related color selections Signed-off-by: Mike Turley <[email protected]> * Add comment Signed-off-by: Mike Turley <[email protected]> * Update snapshots Signed-off-by: Mike Turley <[email protected]> --------- Signed-off-by: Mike Turley <[email protected]> --------- Signed-off-by: Gilles Dubreuil <[email protected]> Signed-off-by: Mike Turley <[email protected]> Co-authored-by: Gilles Dubreuil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PF Label support the following 8 colors "gold" | "red" | "blue" | "cyan" | "green" | "orange" | "purple" | "grey" .
Tag colors depends upon their TagCategory colors which are defined as either keyword names (blue, etc) or hexadecimal values (for the recent ones V3).
Therefore depending on the color of the tag the Label can be displayed with a supported color or will fall back to "grey" (Label default) when not supported.
LabelCustomColor from migtools/lib-ui wraps Label to make tag color supported through CSS properties.
Resolves https://issues.redhat.com/browse/MTA-332