Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: MikeFarah.yq version 4.31.2 #99062

Conversation

mloskot
Copy link
Contributor

@mloskot mloskot commented Mar 9, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?
Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the PullRequest-Error PR is Invalid label Mar 9, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @mloskot,

The package manager bot determined there was an issue with the pull request. Make sure the manifest files are under the manifests\partition\publisher\appname\version directory and only one package version is being modified in your PR. The partition of the path must be the first letter of the publisher in lower-case.

Example:
Path: manifests / m / Microsoft / WindowsTerminal / 1.6.10571.0 / WindowsTerminal.yaml

For details on the error, see the details link below in the build pipeline.

You may also try the Windows Package Manager Manifest Creator

Template: msftbot/validationError/pullRequest

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Mar 9, 2023
Copy link
Contributor

@russellbanks russellbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can only make one version change at a time. This would need to be two PRs.

Also, see mine and Trenly's comment in the linked issue

@microsoft-github-policy-service
Copy link
Contributor

Hello @mloskot,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@mloskot mloskot marked this pull request as draft March 9, 2023 21:34
@mloskot
Copy link
Contributor Author

mloskot commented Mar 9, 2023

@russellbanks I see, thanks. It's been ages since I created my last winget package.
I will split it, once I figure out why the link is not created - following up with comments in the linked issue.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Mar 9, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed PullRequest-Error PR is Invalid Needs-Attention This work item needs to be reviewed by a member of the core team. labels Mar 10, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@mloskot mloskot marked this pull request as ready for review March 10, 2023 00:25
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mloskot mloskot requested a review from russellbanks March 10, 2023 00:48
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Mar 10, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) March 10, 2023 01:17
@microsoft-github-policy-service
Copy link
Contributor

mloskot,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 10, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello mloskot,
Validation has completed.

Template: msftbot/validationCompleted

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 11d9b6f into microsoft:master Mar 10, 2023
@mloskot mloskot deleted the MikeFarah.yq-4.31.2-BDC44B5FB6165D branch March 10, 2023 09:24
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Issue]: Command link not created for MikeFarah.yq
3 participants