Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ditto manifest file to winget #798

Merged
4 commits merged into from
May 23, 2020
Merged

Add Ditto manifest file to winget #798

4 commits merged into from
May 23, 2020

Conversation

sabrogden
Copy link
Contributor

@sabrogden sabrogden commented May 22, 2020 •
edited by ghost
Loading

Microsoft Reviewers: Open in CodeFlow

scott brogden added 2 commits May 22, 2020 11:40
Create 3.22.88.0.yaml
45b657e 
Added Ditto 3.22.88.0 manifest file
Update 3.22.88.0.yaml
d9dbfab 
Updated AppMoniker
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@msftclas
Copy link

msftclas commented May 22, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 22, 2020
@ghost ghost assigned denelon May 22, 2020
@ghost
Copy link

ghost commented May 22, 2020

This submission has moved to manual review.

Update 3.22.88.0.yaml
60bf29b 
Ditto - added 64bit installer to manifest
@wingetbot wingetbot removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 23, 2020
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 23, 2020
@ghost
Copy link

ghost commented May 23, 2020

sabrogden The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

Update 3.22.88.0.yaml
1b44a03 
Removed 64bit, guess they don't support multiple installers
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 23, 2020
@ghost
Copy link

ghost commented May 23, 2020

This submission has moved to manual review.

@ghost ghost assigned KevinLaMS May 23, 2020
@KevinLaMS KevinLaMS added the Validation-Completed Validation passed label May 23, 2020
@ghost
Copy link

ghost commented May 23, 2020

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost
ghost approved these changes May 23, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit 4121724 into microsoft:master May 23, 2020
Reset816 pushed a commit to Reset816/winget-pkgs that referenced this pull request May 26, 2020
@sabrogden @Reset816
Add Ditto manifest file to winget (microsoft#798)
93fba2c 
* Create 3.22.88.0.yaml

Added Ditto 3.22.88.0 manifest file

* Update 3.22.88.0.yaml

Updated AppMoniker

* Update 3.22.88.0.yaml

Ditto - added 64bit installer to manifest

* Update 3.22.88.0.yaml

Removed 64bit, guess they don't support multiple installers

Co-authored-by: scott brogden <[email protected]>
This was referenced May 31, 2020
Closed
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@KevinLaMS KevinLaMS

@denelon denelon

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sabrogden @wingetbot @msftclas @KevinLaMS @denelon