Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Putty 0.73 #748

Merged
2 commits merged into from
May 23, 2020
Merged

Added Putty 0.73 #748

2 commits merged into from
May 23, 2020

Conversation

owenmurr
Copy link
Contributor

@owenmurr owenmurr commented May 22, 2020

Added Putty 0.73

Both x86 and x64 installers included in the manifest. Couldn't find documentation regarding multiple installers in a manifest.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 22, 2020
@ghost
Copy link

ghost commented May 22, 2020

owenmurr The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

Description: PuTTY is a client program for the SSH, Telnet, Rlogin, and SUPDUP network protocols.
Homepage: https://putty.org/
Installers:
- Arch: x64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

winget don't support more than one installer at this time.#706
So at current moment the best way is adding x86 installer instead of x64 one for compatibility

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

I will make this change now.

@ghost ghost removed the Needs: author feedback label May 22, 2020
Remove x64 installer due to winget not supporting multiple installers
@wingetbot wingetbot removed the Manifest-Validation-Error Manifest validation failed label May 22, 2020
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 22, 2020
@ghost ghost assigned denelon May 22, 2020
@ghost
Copy link

ghost commented May 22, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Validation-Completed Validation passed label May 23, 2020
@ghost
Copy link

ghost commented May 23, 2020

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit 6211bdd into microsoft:master May 23, 2020
@owenmurr owenmurr deleted the Putty branch May 24, 2020 06:06
Reset816 pushed a commit to Reset816/winget-pkgs that referenced this pull request May 26, 2020
* Added Putty 0.73

* Removed x64 installer

Remove x64 installer due to winget not supporting multiple installers
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants