Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HWiNFO 6.26 #719

Merged
4 commits merged into from
May 25, 2020
Merged

Add HWiNFO 6.26 #719

4 commits merged into from
May 25, 2020

Conversation

xiaoyang-sde
Copy link

@xiaoyang-sde xiaoyang-sde commented May 22, 2020 •
edited by ghost
Loading

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. label May 22, 2020
@ghost
Copy link

ghost commented May 22, 2020

Berkeley-Reject The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

Here are some common causes for this failure you should consider:

  1. The Sha256 HASH in the manifest does not match the HASH of the installer. Run winget hash to generate the hash.
  2. The URL is not valid. Make sure the URL to the installer is publicly available and valid.
  3. The installer has been identified as malware. If the installer is detected as malware, you can submit the installer to the defender team for analysis as a potential false positive.

@wingetbot wingetbot removed Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. Needs: author feedback labels May 22, 2020
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 22, 2020
@ghost
Copy link

ghost commented May 22, 2020

This submission has moved to manual review.

@ghost ghost assigned denelon May 22, 2020
@ghost ghost assigned xiaoyang-sde May 23, 2020
@ghost
Copy link

ghost commented May 23, 2020

Greetings Berkeley-Reject
During installation testing, this application failed to install with out user input. Did you forget to add Silent or SilentWithProgress switches?

Please investigate a fix and resubmit the Pull Request.

@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels May 23, 2020
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 23, 2020
@ghost ghost assigned RDMacLachlan May 23, 2020
@ghost
Copy link

ghost commented May 23, 2020

This submission has moved to manual review.

@ghost
Copy link

ghost commented May 23, 2020

Greetings Berkeley-Reject
During installation testing, this application failed to install with out user input. Did you forget to add Silent or SilentWithProgress switches?

Please investigate a fix and resubmit the Pull Request.

@ghost ghost removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 23, 2020
This was referenced May 24, 2020
Closed
Closed
@OfficialEsco
Copy link
Contributor

Duplicate: #985 and #952

OfficialEsco
OfficialEsco suggested changes May 24, 2020
View reviewed changes
Copy link
Contributor

@OfficialEsco OfficialEsco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Publisher and Name was the wrong way around, alternatively publisher should be Martin Malik - REALiX.

/VERYSILENT is the correct silent install command.

manifests/REALiX/HWiNFO/6.26.yaml Outdated Show resolved Hide resolved
manifests/REALiX/HWiNFO/6.26.yaml Outdated Show resolved Hide resolved
@ghost ghost removed the Needs: author feedback label May 24, 2020
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 24, 2020
@ghost
Copy link

ghost commented May 24, 2020

This submission has moved to manual review.

@ghost ghost assigned samiranshah-zz May 24, 2020
@KevinLaMS KevinLaMS added the Validation-Completed Validation passed label May 25, 2020
@ghost
Copy link

ghost commented May 25, 2020

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost
ghost approved these changes May 25, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit 82ca9e5 into microsoft:master May 25, 2020
@xiaoyang-sde xiaoyang-sde deleted the hwinfo branch May 25, 2020 11:34
Reset816 pushed a commit to Reset816/winget-pkgs that referenced this pull request May 26, 2020
@OfficialEsco @Reset816
Add HWiNFO 6.26 (microsoft#719)
e52e58c 
* Add HWiNFO 6.26

* Update download link of the installer file

* Add Silent and SilentWithProgress switches (Pull request microsoft#719)

* Apply suggestions from code review

Co-authored-by: Esco <[email protected]>

Co-authored-by: Esco <[email protected]>
@latere-a-latere latere-a-latere mentioned this pull request May 31, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OfficialEsco OfficialEsco OfficialEsco requested changes

Assignees

@xiaoyang-sde xiaoyang-sde

@samiranshah-zz samiranshah-zz

@RDMacLachlan RDMacLachlan

@denelon denelon

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@xiaoyang-sde @wingetbot @OfficialEsco @KevinLaMS @samiranshah-zz @RDMacLachlan @denelon