-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Super tux 0.6.2 #705
Super tux 0.6.2 #705
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
This submission has moved to manual review. |
Greetings MarNicGit : "Microsoft Defender SmartScreen prevented an unrecognized app from starting. Running this app might put your PC at risk." Once Windows Defender Notifications [email protected] confirms the false positive, please remove the label "Needs: author feedback", and we will restart the pull request. |
During installation testing, this app triggered a Microsoft Defender SmartScreen error. We are notifying [email protected] for investigation. |
MarNicGit An issue was identified during the manual review, and the PR request cannot be approved. Please see comments for more information. |
Goodnews, bad news. :( |
@KevinLaMS I'll investigate that later today - I remember the game installing fine on my regular desktop so I suspect it requires opengl which isn't available in virtualised environments |
@KevinLaMS Hey there again! Just tried out some things and it appears that SuperTux simply requires OpenGL in order to run. My testing environment (the win10 dev env) experienced the silent crash you experienced, but after adding the (unsupported) RemoteFX adapter to my VM the game would start up. This also explains why it runs fine on my desktop. |
@marnicgit I'll add a "Dependency" label to this issue. We're getting closer to starting work on dependencies. This manifest is quite old, so it would need to be updated to the new schema as well. |
Commenting to prevent auto-closure, will provide a fix somewhere this week |
I'm converting this to draft, probably gonna redo the manifest later today. @denelon it looks like the PR was blocked because Super tux wouldn't run in the dev environment because it requires opengl, which sounds like it simply doesn't work in the dev environment. Osu! doesn't run in dev either because of the same issue but that PR did get passed, see #1067 and subsequent PR's referencing that one. Do you want to keep it blocked? I'll test it out again to see if anything changed, both with and without RemoteFX. |
@marnicgit We've got dependencies in the v1.1 milestone. I'm not sure if that alone will fix things in the virtualized environment. If you don't mind, add your 👍 to #12906. If you are able to get the package to work, the "Blocking-Issue" label doesn't prevent the validation pipelines from running. We're using the label to prevent duplicate submissions for packages from different users. Once the support for the "Blocking-Issue" is in place, we will kick the builds off again to see if the manifests pass validation. You've already done the work to build a manifest, so we're trying to keep the value of your effort by keeping the PR open, but it's up to you 😊. |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
@marnicgit The package manager bot determined that the metadata was not compliant. As mentioned in this tweet, in winget-cli and winget-pkgs we have moved to the 1.0 format. Please update your manifest to the new format and submit again. |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hello @wingetbot! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validation has completed
Part of latere-a-latere#4
Microsoft Reviewers: Open in CodeFlow