Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super tux 0.6.2 #705

Merged
6 commits merged into from
May 14, 2021
Merged

Super tux 0.6.2 #705

6 commits merged into from
May 14, 2021

Conversation

latere-a-latere
Copy link
Contributor

@latere-a-latere latere-a-latere commented May 22, 2020

Part of latere-a-latere#4

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 22, 2020
@ghost ghost assigned KevinLaMS May 22, 2020
@ghost
Copy link

ghost commented May 22, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Validation-SmartScreen Microsoft Defender SmartScreen triggered during manual validation label May 22, 2020
@ghost ghost assigned latere-a-latere May 22, 2020
@ghost
Copy link

ghost commented May 22, 2020

Greetings MarNicGit :
During installation testing, this app triggered a Microsoft Defender SmartScreen error.

"Microsoft Defender SmartScreen prevented an unrecognized app from starting. Running this app might put your PC at risk."
If you believe this file has been incorrectly classified as malware, please consider submitting it here: https://www.microsoft.com/en-us/wdsi/filesubmission

Once Windows Defender Notifications [email protected] confirms the false positive, please remove the label "Needs: author feedback", and we will restart the pull request.

@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels May 22, 2020
@latere-a-latere
Copy link
Contributor Author

I've submitted the installer to Microsoft and they have confirmed that the installer does not contain malware.

image

@ghost ghost removed the Needs: author feedback label May 23, 2020
@KevinLaMS KevinLaMS added Validation-SmartScreen Microsoft Defender SmartScreen triggered during manual validation and removed Validation-SmartScreen Microsoft Defender SmartScreen triggered during manual validation labels Jun 5, 2020
@ghost
Copy link

ghost commented Jun 5, 2020

During installation testing, this app triggered a Microsoft Defender SmartScreen error.

We are notifying [email protected] for investigation.

@KevinLaMS KevinLaMS added Validation-Error General Error during testing. Requires we provide comment to author. and removed Needs SmartScreen Investigation Validation-SmartScreen Microsoft Defender SmartScreen triggered during manual validation labels Jun 11, 2020
@ghost
Copy link

ghost commented Jun 11, 2020

MarNicGit An issue was identified during the manual review, and the PR request cannot be approved. Please see comments for more information.
Please address the issue and resubmit, or if you disagree with this resolution, please raise an issue and flag this PR for further discussion.

@KevinLaMS
Copy link
Contributor

Goodnews, bad news. :(
I worked with smartscreen to get the reputation up and it installs great. The bad news is that I cannot get the app to run. It just seems to crash. Is there a dependency missing?

@latere-a-latere
Copy link
Contributor Author

@KevinLaMS I'll investigate that later today - I remember the game installing fine on my regular desktop so I suspect it requires opengl which isn't available in virtualised environments

@ghost ghost removed the Needs: author feedback label Jun 11, 2020
@latere-a-latere
Copy link
Contributor Author

@KevinLaMS Hey there again! Just tried out some things and it appears that SuperTux simply requires OpenGL in order to run. My testing environment (the win10 dev env) experienced the silent crash you experienced, but after adding the (unsupported) RemoteFX adapter to my VM the game would start up. This also explains why it runs fine on my desktop.

@KevinLaMS KevinLaMS added the Blocking-Issue Manifest validation is blocked by a known issue. label Jul 22, 2020
@denelon
Copy link
Contributor

denelon commented May 4, 2021

@marnicgit I'll add a "Dependency" label to this issue. We're getting closer to starting work on dependencies. This manifest is quite old, so it would need to be updated to the new schema as well.

@latere-a-latere
Copy link
Contributor Author

Commenting to prevent auto-closure, will provide a fix somewhere this week

@ghost ghost added Needs: Attention and removed Needs: author feedback No-Recent-Activity No activity has occurred on this work item for seven days. labels May 11, 2021
@latere-a-latere latere-a-latere marked this pull request as draft May 14, 2021 08:40
@latere-a-latere
Copy link
Contributor Author

I'm converting this to draft, probably gonna redo the manifest later today. @denelon it looks like the PR was blocked because Super tux wouldn't run in the dev environment because it requires opengl, which sounds like it simply doesn't work in the dev environment. Osu! doesn't run in dev either because of the same issue but that PR did get passed, see #1067 and subsequent PR's referencing that one.

Do you want to keep it blocked? I'll test it out again to see if anything changed, both with and without RemoteFX.

@denelon
Copy link
Contributor

denelon commented May 14, 2021

@marnicgit We've got dependencies in the v1.1 milestone. I'm not sure if that alone will fix things in the virtualized environment. If you don't mind, add your 👍 to #12906.

If you are able to get the package to work, the "Blocking-Issue" label doesn't prevent the validation pipelines from running. We're using the label to prevent duplicate submissions for packages from different users. Once the support for the "Blocking-Issue" is in place, we will kick the builds off again to see if the manifests pass validation.

You've already done the work to build a manifest, so we're trying to keep the value of your effort by keeping the PR open, but it's up to you 😊.

@ghost ghost removed the Blocking-Issue Manifest validation is blocked by a known issue. label May 14, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 14, 2021
@ghost
Copy link

ghost commented May 14, 2021

@marnicgit The package manager bot determined that the metadata was not compliant.

As mentioned in this tweet, in winget-cli and winget-pkgs we have moved to the 1.0 format. Please update your manifest to the new format and submit again.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://github.com/microsoft/winget-cli/blob/master/doc/ManifestSpecv1.0.md)
For details on the error, see the details link below in the build pipeline.

@ghost ghost removed Needs: author feedback Manifest-Validation-Error Manifest validation failed labels May 14, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@latere-a-latere latere-a-latere marked this pull request as ready for review May 14, 2021 21:16
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 14, 2021
@ghost
Copy link

ghost commented May 14, 2021

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit a349419 into microsoft:master May 14, 2021
@latere-a-latere latere-a-latere deleted the SuperTux-0.6.2 branch February 22, 2024 12:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Dependencies Validation-Completed Validation passed Validation-Error General Error during testing. Requires we provide comment to author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants