Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Huawei.HiSuite version 11.0.0.580 #37971

Closed
wants to merge 10 commits into from
Closed

Huawei.HiSuite version 11.0.0.580 #37971

wants to merge 10 commits into from

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Dec 16, 2021 •
edited
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Dec 16, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Dec 16, 2021
@Dragon1573
Copy link
Contributor Author

  1. Installed successfully on my own device with winget install -m command. Could you please do me a favour if there're still mistakes in the manifests?
  2. The latest version of this application is v11.0.0.590. It doesn't released on the offical page, so I can't figure out the downloading URL of that version. It will popup a dialog asking you for upgrading when you first launch the application.

@ItzLevvie ItzLevvie mentioned this pull request Dec 16, 2021
Closed
@Dragon1573
Copy link
Contributor Author

@ItzLevvie

I'm really sorry for submitting such a wierd InstallerURL in the manifest. 🙏🏼

In the offical homepage of this application, the Download button is associated with a shorter URL. But I can't figure out if the associated URL is generated dynamically.

image

The wierd so-long URL is copied from the file-downloader embedded in Microsoft Edge. Maybe it's not a good idea?

@ghost ghost removed the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Dec 17, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Dec 17, 2021
@Dragon1573
Update Huawei.HiSuite manifests
53e6315 
- Edit "Publisher", "Author" & "PackageName" to match the content displayed in Windows Control Panel.
- TODO: Still unable to locate a shorter direct link of "InstallerUrl".

Signed-off-by: Dragon1573 <[email protected]>
@Dragon1573
Renew "Descriptions"
0dcf3a1 
- The "ShortDescription" is the slogan written in the package offical homepage.

Signed-off-by: Dragon1573 <[email protected]>
@Dragon1573
Reformat YAML manifests
aaae60e 
- Reformatted by Visual Studio Code

Signed-off-by: Dragon1573 <[email protected]>
@ghost ghost removed the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Dec 17, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Dec 17, 2021
@SpecterShell
Copy link
Contributor

SpecterShell commented Dec 17, 2021 •
edited
Loading

#25793
#29093
#30806
The installer itself requires VC++, so it cannot pass before the dependency feature is implemented in WinGet.
The short URL from the homepage is enough.

@Dragon1573
Copy link
Contributor Author

The installer itself requires VC++, so it cannot pass before the dependency feature is implemented in WinGet.

I haven't searched for those previous Pull Requests. It's my fault. 😢

Now I get it. Can't wait for such a usefull features in future version of WinGet! 🎉

The short URL from the homepage is enough.

OKay, thanks for your instructions. I'll change the wierd InstallerUrl to shorter one.

@Dragon1573
Huawei HiSuite: Shorten the "InstallerUrl"
a22e8c3 
Signed-off-by: Dragon1573 <[email protected]>
@Dragon1573
[Important] Attach package dependencies
e9e6af9 
- HiSuite needs "Microsoft Visual C++ 2015-2019 Redistribution (x86)" as a required runtime environment
- [Note] Dependency feature of Winget is currently not implemented, should wait until the feature officially released
- Related microsoft#25793, microsoft#29093 and microsoft#30806

Signed-off-by: Dragon1573 <[email protected]>
@Dragon1573
Add more informations about the package
6df9d11 
Signed-off-by: Dragon1573 <[email protected]>
@ghost ghost removed the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Dec 17, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Dec 17, 2021
ItzLevvie
ItzLevvie suggested changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manifest validation succeeded with warnings:
image

Shortened URL works fine :)

but seems like installation is blocked by VC++ dependency:
image

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Dec 17, 2021
@Dragon1573
Huawei.Hisuite: Fix indentation error
a771aa4 
- Wrong indentation caused warnings in manifest validation

Signed-off-by: Dragon1573 <[email protected]>
@Dragon1573
Update "FileExtensions" Field
99f0fcb 
- "*.hap" is a new application installer type available for HarmonyOS

Signed-off-by: Dragon1573 <[email protected]>
@ghost ghost removed Needs-Author-Feedback This needs a response from the author. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. labels Dec 18, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Dragon1573
Copy link
Contributor Author

#37971 (review)

Manifest validation succeeded with warnings

Oops?! There's an indentation error in my installer.yaml file 🤣 Now it's fixed by a771aa4.

#37971 (review)

Shortened URL works fine :)

Okay, that's nice! 🎉

Nice

#37971 (review)

Seems like installation is blocked by VC++ dependency

My device is previously installed dual version of Microsoft Visual C++ 2015-2019 Redistributable. But when I invoke the uninstallation process, it seems that Hisuite itself is not "silent-able". I have no idea how to handle it this time ...

1639787150938

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Dec 18, 2021
ItzLevvie
ItzLevvie suggested changes Dec 18, 2021
View reviewed changes
Copy link
Contributor

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can set this PR in draft mode until dependency support works in WinGet.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Dec 18, 2021
@Dragon1573
Copy link
Contributor Author

You can set this PR in draft mode until dependency support works in WinGet.

@ItzLevvie Okay, thank you for your remindings.

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Dec 19, 2021
@Dragon1573 Dragon1573 marked this pull request as draft December 19, 2021 09:01
@denelon denelon added Blocking-Issue Manifest validation is blocked by a known issue. Dependencies and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Feb 8, 2022
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 13, 2022
@Dragon1573 Dragon1573 mentioned this pull request Mar 15, 2022
Closed
5 tasks
@Dragon1573
Copy link
Contributor Author

Someone else fixed this issue. This pull request can be closed without merging.

@Dragon1573 Dragon1573 closed this Oct 22, 2022
@Dragon1573 Dragon1573 deleted the autogenerated/Huawei.HiSuite/3d6fbc8a-5132-4333-81da-dd9f53c1de3f branch November 2, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Assignees
No one assigned
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Dependencies Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Dragon1573 @wingetbot @SpecterShell @ItzLevvie @denelon