Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package does not install due to the file name exceeding the maximum amount of characters #1808

Closed
ItzLevvie opened this issue Dec 16, 2021 · 2 comments · Fixed by #1842
Closed
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@ItzLevvie
Copy link

ItzLevvie commented Dec 16, 2021

Brief description of your issue

image

Logs from the DiagOutputDir folder with --verbose-logs:

  1. winget validate = https://pastebin.com/raw/NxWVKnvg
  2. winget install = https://pastebin.com/raw/QdchskSe

Steps to reproduce

Install the WinGet package from microsoft/winget-pkgs#37971

^ https://github.com/Dragon1573/winget-pkgs/tree/bf22a2a5a907bef7cf7c4d00595ede8745b7e84d/manifests/h/Huawei/HiSuite/11.0.0.580

Expected behavior

For the WinGet package to install successfully on my PC.

Actual behavior

Due to how weird the file name is for the installer, it has seemingly exceeded the maximum amount of characters you can write in a file name.

Perhaps if WinGet spots a file name that is too long, it should possibly truncate it to avoid this issue?

Environment

Windows Package Manager (Preview) v1.2.3411-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22523.1000
Package: Microsoft.DesktopAppInstaller v1.17.3411.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale
@ghost ghost added the Needs-Triage Issue need to be triaged label Dec 16, 2021
@ItzLevvie ItzLevvie changed the title Installer File Name may have hit MAX_PATH An installer's file name may have hit MAX_PATH Dec 16, 2021
@ItzLevvie ItzLevvie changed the title An installer's file name may have hit MAX_PATH An installer's file name may have hit MAX_PATH and errors out Dec 16, 2021
@ItzLevvie ItzLevvie changed the title An installer's file name may have hit MAX_PATH and errors out An installer's file name may have hit the maximum amount of characters and errors out Dec 16, 2021
@ItzLevvie ItzLevvie changed the title An installer's file name may have hit the maximum amount of characters and errors out Package does not install due to exceeding the maximum amount of characters in the installer's file name Dec 16, 2021
@ItzLevvie ItzLevvie changed the title Package does not install due to exceeding the maximum amount of characters in the installer's file name Package does not install due to the file name exceeding the maximum amount of characters Dec 16, 2021
@denelon
Copy link
Contributor

denelon commented Dec 16, 2021

That's interesting. I haven't seen one that long before. We should take a look at both the URL length and the installer name length. It would also make for a strange UAC where we try to use the installer name to help provide more clarity.

@denelon denelon added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage Issue need to be triaged labels Dec 16, 2021
@vedantmgoyal9
Copy link
Contributor

vedantmgoyal9 commented Dec 16, 2021

That more looks like a password generated using some program 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants