Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: vivainio.RoughGrep version 3.14.3 #196149

Merged
merged 1 commit into from
Dec 12, 2024
Merged

New package: vivainio.RoughGrep version 3.14.3 #196149

merged 1 commit into from
Dec 12, 2024

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Dec 4, 2024 •
edited by microsoft-github-policy-service bot
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Manual validation

Image
Image

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot added zip-binary Depends on library files that aren't available via symlink Needs-Author-Feedback This needs a response from the author. labels Dec 4, 2024
@Dragon1573
Copy link
Contributor Author

@Trenly @stephengillie,

The zip-binary Depends on library files that aren't available via symlink label should be removed both in this pull request and the related issue #182569 🙏🏼

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Dec 4, 2024
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Dec 4, 2024
@Trenly
Copy link
Contributor

Trenly commented Dec 4, 2024 •
edited
Loading

@Trenly @stephengillie,

The zip-binary Depends on library files that aren't available via symlink label should be removed both in this pull request and the related issue #182569 🙏🏼

Why? It does depend on DLLs in the zip file and is a Zipped Binary

The label isn’t blocking the PR

@stephengillie
Copy link
Collaborator

Verify:
image
The version number displayed by the application seems very different from the version number written to the Registry. Should a DisplayVersion be used here?

@stephengillie stephengillie added Validation-Completed Validation passed zip-binary Depends on library files that aren't available via symlink Needs-Author-Feedback This needs a response from the author. and removed Validation-Executable-Error Needs-Attention This work item needs to be reviewed by a member of the core team. zip-binary Depends on library files that aren't available via symlink Validation-Completed Validation passed labels Dec 11, 2024
@Dragon1573
Copy link
Contributor Author

The version number displayed by the application seems very different from the version number written to the Registry. Should a DisplayVersion be used here?

NO. rg.exe is provided by package identifier BurntSushi.ripgrep.MSVC. rgg.exe is our target executable. Screenshots are shown in Manual validation section.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Dec 11, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 51e6623 into microsoft:master Dec 12, 2024
2 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Dec 12, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@Dragon1573 Dragon1573 deleted the issues/182569 branch December 12, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

Assignees

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Attention This work item needs to be reviewed by a member of the core team. New-Package Publish-Pipeline-Succeeded Validation-Completed Validation passed zip-binary Depends on library files that aren't available via symlink
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Request]: RoughGrep
4 participants
@Dragon1573 @wingetbot @Trenly @stephengillie