Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Request]: RoughGrep #182569

Closed
1 task done
vivainio opened this issue Oct 13, 2024 · 4 comments · Fixed by #196149
Closed
1 task done

[Package Request]: RoughGrep #182569

vivainio opened this issue Oct 13, 2024 · 4 comments · Fixed by #196149
Labels
In-PR Package-Request This is a request for a package (new or updated version) zip-binary Depends on library files that aren't available via symlink

Comments

@vivainio
Copy link

How can we help?

None

Please read and ensure the following

  • The installer meets the above requirements

Please provide the following information

Download Page Url: https://github.com/vivainio/RoughGrep/releases/tag/v3.14.3
Publisher: Ville Vainio
Package Name: vivainio.RoughGrep
Description: User interface for RipGrep
Package Version: 3.14.3
Installer Url: https://github.com/vivainio/RoughGrep/releases/download/v3.14.3/RoughGrep-3.14.3.zip

@vivainio vivainio added Help-Wanted This is a good candidate work item from the community. Package-Request This is a request for a package (new or updated version) labels Oct 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Oct 13, 2024
@vivainio
Copy link
Author

I am the maintainer of this application, and I am willing to publish it in WinGet in linked PR. It's a portable zip file

@Trenly
Copy link
Contributor

Trenly commented Oct 14, 2024

Although it is a portable application, it depends on DLLs, therefore is blocked until the release of 1.9 manifests in the validation pipelines

[Policy] Zip Binary

@microsoft-github-policy-service microsoft-github-policy-service bot added zip-binary Depends on library files that aren't available via symlink Blocking-Issue Manifest validation is blocked by a known issue. and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Oct 14, 2024
@Dragon1573
Copy link
Contributor

Since RoughGrep is a *.sln Visual Studio Solution with *.csproj C# Visual Studio Project, I think it would be great introducing WiX to the solution and package the project to an MSI install wizard.

@Trenly
Copy link
Contributor

Trenly commented Dec 3, 2024

[Policy] Unblocked; Will require ManifestVersion: 1.9.0 with ArchiveBinariesDependOnPath: true

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Blocking-Issue Manifest validation is blocked by a known issue. label Dec 3, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added In-PR and removed Help-Wanted This is a good candidate work item from the community. labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In-PR Package-Request This is a request for a package (new or updated version) zip-binary Depends on library files that aren't available via symlink
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants