Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for PowerShell cmdlets in admin mode #2642
Support for PowerShell cmdlets in admin mode #2642
Changes from 41 commits
6307854
00c91f1
ccaa1dc
e3dda96
4d732c2
0febd74
0a11caa
6813160
f1d7b45
74414ae
71633e0
adc0c05
bd96353
04524b6
0b68135
7626067
a7a8c78
9fe098e
b9d7aff
ddb488b
987fad6
f0836e6
9590eae
ecd46bd
d1e55e7
708e082
0809143
1ca4064
5075f5b
8a9b956
8f68d4d
cf5a0ef
b149685
eabc286
d4c466f
38a20af
6918fb9
3ff22d1
b66ebb7
e1aeb9e
6f4885b
3c19802
9957cd8
190a6b9
a305bab
5a9d0a2
ffef20d
7b1362a
9d587c8
4ff0887
0d4edb0
bb04705
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Since all tests target x64, this comment should move to around top of the test class.
And do we plan to target x86 in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To support x86 tests, we will need to manually install powershell core (x86) and have the E2E tests target that when running the tests. Since this is mainly just for smoke-testing, I don't currently have plans to target x86. Testing should be carried out through the Pester framework which will be more thorough since that is required for publishing to the gallery.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this require changes in AppInstaller manifest or this is just for dev testing