-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for PowerShell cmdlets in admin mode #2642
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnMcPMS
previously requested changes
Oct 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/WinGetServer/WinGetServer.idl
is showing as binary; it probably needs some BOM added or removed to get it to show as text here.
src/PowerShell/Microsoft.WinGet.Client/Helpers/ComObjectFactory.cs
Outdated
Show resolved
Hide resolved
src/PowerShell/Microsoft.WinGet.Client/Helpers/ComObjectFactory.cs
Outdated
Show resolved
Hide resolved
src/PowerShell/Microsoft.WinGet.Client/Properties/Resources.resx
Outdated
Show resolved
Hide resolved
ghost
added
the
Needs-Author-Feedback
Issue needs attention from issue or PR author
label
Oct 27, 2022
ghost
removed
the
Needs-Author-Feedback
Issue needs attention from issue or PR author
label
Nov 2, 2022
/azp run |
Azure Pipelines failed to run 1 pipeline(s). |
/azp run |
Azure Pipelines failed to run 1 pipeline(s). |
/azp run |
Azure Pipelines failed to run 1 pipeline(s). |
/azure-pipelines.yml (Line: 174, Col: 12): Unexpected value '' |
yao-msft
reviewed
Nov 24, 2022
yao-msft
reviewed
Nov 24, 2022
yao-msft
reviewed
Nov 24, 2022
yao-msft
reviewed
Nov 24, 2022
yao-msft
reviewed
Nov 24, 2022
yao-msft
reviewed
Nov 24, 2022
yao-msft
reviewed
Nov 24, 2022
yao-msft
reviewed
Nov 24, 2022
yao-msft
reviewed
Nov 24, 2022
yao-msft
reviewed
Nov 24, 2022
msftrubengu
reviewed
Nov 30, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yao-msft
reviewed
Dec 3, 2022
yao-msft
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #221
Initial Proof of Concept: master...JohnMcPMS:winget-cli:ps-admin
This PR adds support for calling an elevated PowerShell and having elevation flow through the installer.
Changes:
Microsoft Reviewers: Open in CodeFlow