Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check symlink target before removal #2242

Merged
merged 4 commits into from
Jun 17, 2022
Merged

Check symlink target before removal #2242

merged 4 commits into from
Jun 17, 2022

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Jun 13, 2022 •
edited by ghost
Loading

Resolves #2190

Changes:

  • Checks the target of the portable symlink to verify that it matches the target exe path that is stored in ARP.

Tests:

  • Upgraded E2E tests to .NET6.0 to use File.CreateSymbolicLink()
  • Added Uninstall Test to verify that the symlink will not be deleted if it does not match the target exe path.
Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner June 13, 2022 23:54
@ghost ghost added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jun 13, 2022
@ryfu-msft ryfu-msft merged commit d551743 into microsoft:master Jun 17, 2022
@ryfu-msft ryfu-msft deleted the symlinkBug branch June 17, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trenly Trenly Trenly left review comments

@JohnMcPMS JohnMcPMS JohnMcPMS approved these changes

Assignees
No one assigned
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Portable uninstall should check target path of symlink before removal
3 participants
@ryfu-msft @JohnMcPMS @Trenly