Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portable uninstall should check target path of symlink before removal #2190

Closed
ryfu-msft opened this issue May 26, 2022 · 0 comments · Fixed by #2242
Closed

Portable uninstall should check target path of symlink before removal #2190

ryfu-msft opened this issue May 26, 2022 · 0 comments · Fixed by #2242
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@ryfu-msft
Copy link
Contributor

Brief description of your issue

Currently, Portable uninstall only checks that the portable symlink path matches what is recorded in ARP. However, the symlink could be modified to point to a different target exe. We should verify that the target of the symlink points to the correct portable exe that we placed down during installation.

Steps to reproduce

Modify symlink to point to another exe. Uninstall will still remove the symlink even though it is modified.

Expected behavior

Symlink should not be removed as it has been modified by the user.

Actual behavior

If the symlink path matches the symlink path recorded in ARP, the symlink will always be removed regardless of whether it has been modified by the user.

Environment

Windows Package Manager 1.3.1391-preview
@ghost ghost added the Needs-Triage Issue need to be triaged label May 26, 2022
@ryfu-msft ryfu-msft self-assigned this May 26, 2022
@ryfu-msft ryfu-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage Issue need to be triaged labels May 26, 2022
@denelon denelon added this to the v1.4-Client milestone Jun 2, 2022
@ghost ghost added the In-PR Issue related to a PR label Jun 13, 2022
@ghost ghost added Resolution-Fix-Committed and removed In-PR Issue related to a PR labels Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants