Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for UnsupportedArguments #2216

Merged
merged 14 commits into from
Jun 21, 2022
Merged

Add support for UnsupportedArguments #2216

merged 14 commits into from
Jun 21, 2022

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Jun 3, 2022 •
edited by ghost
Loading

Resolves #1277

Changes:

  • Fixes the schema as UnsupportedArguments was defined by not included in the installer object.
  • Checks if arguments are provided that match the unsupportedArguments present in the manifest and shows an error message to the user.

Tests:

  • Verifies that the correct error message is shown if an unsupported argument is provided
Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner June 3, 2022 18:52
@ghost ghost added Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client. labels Jun 3, 2022
@ryfu-msft ryfu-msft requested a review from florelis June 6, 2022 19:26
florelis
florelis approved these changes Jun 6, 2022
View reviewed changes
src/AppInstallerCLICore/Workflows/InstallFlow.cpp Outdated Show resolved Hide resolved
src/AppInstallerCLICore/Workflows/InstallFlow.cpp Outdated Show resolved Hide resolved
src/AppInstallerCLICore/Workflows/InstallFlow.cpp Outdated Show resolved Hide resolved
src/AppInstallerCLICore/Workflows/InstallFlow.h Outdated Show resolved Hide resolved
src/AppInstallerCLITests/WorkFlow.cpp Outdated Show resolved Hide resolved
src/AppInstallerCommonCore/Manifest/ManifestCommon.cpp Outdated Show resolved Hide resolved
JohnMcPMS
JohnMcPMS requested changes Jun 7, 2022
View reviewed changes
src/AppInstallerCLICore/Workflows/InstallFlow.cpp Outdated Show resolved Hide resolved
src/AppInstallerCLICore/Workflows/InstallFlow.cpp Outdated Show resolved Hide resolved
src/AppInstallerCommonCore/Manifest/ManifestCommon.cpp Outdated Show resolved Hide resolved
@ghost ghost added the Needs-Author-Feedback Issue needs attention from issue or PR author label Jun 7, 2022
@ghost ghost removed the Needs-Author-Feedback Issue needs attention from issue or PR author label Jun 7, 2022
@ryfu-msft ryfu-msft requested a review from JohnMcPMS June 7, 2022 22:53
JohnMcPMS
JohnMcPMS requested changes Jun 7, 2022
View reviewed changes
src/AppInstallerCLICore/Argument.h Outdated Show resolved Hide resolved
src/AppInstallerCLICore/Workflows/InstallFlow.cpp Outdated Show resolved Hide resolved
@ghost ghost added the Needs-Author-Feedback Issue needs attention from issue or PR author label Jun 7, 2022
@ghost ghost removed the Needs-Author-Feedback Issue needs attention from issue or PR author label Jun 9, 2022
@ryfu-msft ryfu-msft requested a review from JohnMcPMS June 9, 2022 18:38
@ghost ghost added the Needs-Author-Feedback Issue needs attention from issue or PR author label Jun 16, 2022
@ghost ghost removed the Needs-Author-Feedback Issue needs attention from issue or PR author label Jun 17, 2022
@ryfu-msft ryfu-msft merged commit c854548 into microsoft:master Jun 21, 2022
@Trenly Trenly mentioned this pull request Jun 22, 2022
Merged
@ryfu-msft ryfu-msft deleted the UnsupportedArgs branch July 29, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trenly Trenly Trenly left review comments

@florelis florelis florelis approved these changes

@JohnMcPMS JohnMcPMS JohnMcPMS approved these changes

Assignees
No one assigned
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability to identify unsupported arguments
4 participants
@ryfu-msft @JohnMcPMS @Trenly @florelis