Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to identify unsupported arguments #1277

Closed
denelon opened this issue Jul 13, 2021 · 1 comment · Fixed by #2216
Closed

Add the ability to identify unsupported arguments #1277

denelon opened this issue Jul 13, 2021 · 1 comment · Fixed by #2216
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Milestone

Comments

@denelon
Copy link
Contributor

denelon commented Jul 13, 2021

Description of the new feature/enhancement

Some installers don't support certain arguments like "--location".
See microsoft/winget-pkgs#20228

Others may not support "--log"

Proposed technical implementation details (optional)

Enhance the schema and the client to inform users when these are known conditions:
"--location"
"--log"

Note: we may update the description of this issue to identify other scenarios

Installers:
  - InstallerType: exe
    InstallerArchitecture: x64
    InstallerSHA256: 12341234123412341234123412341234123412341234
    InstallerURL: https://www.contoso.com/awesomeapp/1.0.0/awesomeapp.x64.exe
    UnsupportedArguments:
      - Location
      - Log
@denelon denelon added the Issue-Feature This is a feature request for the Windows Package Manager client. label Jul 13, 2021
@ghost ghost added the Needs-Triage Issue need to be triaged label Jul 13, 2021
@denelon denelon removed the Needs-Triage Issue need to be triaged label Jul 13, 2021
@denelon denelon added this to the Backlog - Windows Package Manager milestone Jul 13, 2021
@denelon denelon added the Area-Manifest This may require a change to the manifest label Jul 15, 2021
@jazzdelightsme
Copy link
Member

Another idea: give the manifest author the ability to add a bit more information about the unsupported argument. For example, it would be great if I ran "winget install vim --location C:\vim" and it not only told me that "--location is not supported for this package", but something more (supplied by the manifest author), like "--location is not supported for this package: tracked by https://github.com/vim/vim-win32-installer/issues/219"

@ghost ghost added the In-PR Issue related to a PR label Jun 3, 2022
@ghost ghost added Resolution-Fix-Committed and removed In-PR Issue related to a PR labels Jun 21, 2022
@denelon denelon modified the milestones: Backlog-Client, v1.4-Client Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants