Fixed issues preventing compilation on VS 2022 17.1.

[jedieaston]

• Have you signed the Contributor License Agreement?
• Are you working against an Issue?

---

For some reason¹, Visual Studio 2022's newest update (17.1.0) made source breaking changes to the C++ compiler. In two instances, these prevented winget from compiling. I believe @yao-msft was running into these issues in #1990, but here's the fix.

Basically, there was a conformance change to the compiler where if you had a static_assert that could be evaluated without knowing the type, then the compiler would always evaluate it to the same value. Many of the static_assert calls that were checking to see if a type had an override had to be made dependent on the type so the compiler wouldn't optimize the check away.

More reading here: https://docs.microsoft.com/en-us/cpp/overview/cpp-conformance-improvements?view=msvc-170#error-on-a-non-dependent-static_assert

Microsoft Reviewers: Open in CodeFlow

Footnotes

1. Most likely because engagement with the 17.0 error list was too low ;) ↩

[yao-msft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).