Code

Add Package Dependencies to index. #1667

Code

Merged

hackean-msft merged 167 commits intomicrosoft:mastermicrosoft/winget-cli:masterfrom hackean-msft:user/akalagbe/dependencies-index-creationhackean-msft/winget-cli:user/akalagbe/dependencies-index-creationCopy head branch name to clipboardDec 3, 2021

+1,737-107

Commits

Commits on Jun 4, 2021

• first tests for show depenencies feature

  fzanollo

  committed
  9c72b02

• show dependencies feature for show, install, need to change message

  fzanollo

  committed
  0a81ec5

Commits on Jun 9, 2021

• showflow output changed

  fzanollo

  committed
  b416985

Commits on Jun 10, 2021

• install commands shows dependencies as in specs

  fzanollo

  committed
  c848824

• tests for informing dependencies on commands: show, install, upgrade, import

  fzanollo

  committed
  688cbe5

Commits on Jun 11, 2021

• refactor install flow

  fzanollo

  committed
  7b488f1

• change import command from install flow (install multiple)

  fzanollo

  committed
  c8d02ea

• import shows all dependencies together

  fzanollo

  committed
  72fd209

• show dependencies for validate and uninstall

  fzanollo

  committed
  d6d0c53

• tests for validate and uninstall

  fzanollo

  committed
  d3063f2

Commits on Jun 12, 2021

• create show dependencies exp feature

  fzanollo

  committed
  9d05f6f

Commits on Jun 14, 2021

• test for validate command

  fzanollo

  committed
  e3ccc8e

• put functionality under experimental feature check

  fzanollo

  committed
  44fe9e2

• enable show dep experimental feature on unit test cases

  fzanollo

  committed
  a69b930

Commits on Jun 15, 2021

• change experimental feature name

  fzanollo

  committed
  8bb3aa1

• remove info stream characters on testcase

  fzanollo

  committed
  9737ae1

• move check for exp feature inside report function, create new DependenciesFlow

  fzanollo

  committed
  49c7fea

• DependenciesFlow header and cpp inside Workflow

  fzanollo

  committed
  74d29ff

Commits on Jun 18, 2021

• �change representation of Dependency, create DependencyType and DependencyList; add Dependency to context data

  fzanollo

  committed
  b7590c3

• dependencies context data is of type DependencyList (not optional)

  fzanollo

  committed
  b04225a

• fix spelling errors

  fzanollo

  committed
  2a620d8

• ApplyTo function, can receibe a lambda function to apply on specific DpeendencyType

  fzanollo

  committed
  40e05b4

Commits on Jun 22, 2021

• localize user strings, code style changes, validate report dependencies task divided, creates ValidateFlow

  fzanollo

  committed
  d8c411f

• change uninstall flow (gets dependencies from package version), make DependencyList.dependencies private, code style

  fzanollo

  committed
  9f3961a

• add missing report dep on upgrade

  fzanollo

  committed
  1c6347f

Commits on Jun 23, 2021

• Update src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw

  Show description for c785b14
  

  fzanollo

  and

  JohnMcPMS

  authored
  c785b14

• compare id with ICU case insensitive

  fzanollo

  committed
  0a31f79

• move dependencies related functions to DependenciesFlow, ReportDependencies is now a WorkflowTask receiving resource string id

  fzanollo

  committed
  af7b09c

• TODO to get dependencies on uninstall context, remove testcase for now, move dependency related function to DependenciesFlow

  fzanollo

  committed
  8fce81d

• wfIds not temporary

  fzanollo

  committed
  af036e4

• DependencyList Add function checks for existence and updates min version if needed

  fzanollo

  committed
  3388ea7

Commits on Jun 24, 2021

• root dependencies are used when installer are not present, otherwise installer are preferred

  fzanollo

  committed
  f07fdc6

• add tests names to spelling expect

  fzanollo

  committed
  5eb6270

• merge commits from master

  fzanollo

  committed
  c8e9e27

• style and details

  fzanollo

  committed
  0bbe093

• fix merge conflicts

  fzanollo

  committed
  f0f3676

• spellcheck exception

  fzanollo

  committed
  dd03b85

Commits on Jun 28, 2021

• detail when adding dep

  fzanollo

  committed
  2985cd5

Commits on Jun 29, 2021

• proto

  fzanollo

  committed
  021e326

• divide identity report and installation disclaimer from actual installation

  fzanollo

  committed
  4e623d4

Commits on Jun 30, 2021

• Merge branch 'showDependenciesFeature' into dependencyGraph

  fzanollo

  committed
  8f39bd6

Commits on Jul 6, 2021

• proto tests

  fzanollo

  committed
  160242b

Commits on Jul 7, 2021

• testing

  fzanollo

  committed
  06ddcd6

Commits on Jul 8, 2021

• questions

  fzanollo

  committed
  e6d7b82

Commits on Jul 12, 2021

• test for dependency graph and fixes

  fzanollo

  committed
  62ef1c7

• check loop logic change

  fzanollo

  committed
  0ed66ee

• const & dep graph

  fzanollo

  committed
  6eb87bf

• with installation order

  fzanollo

  committed
  d69b3e3

• two more tests

  fzanollo

  committed
  b67708c

• change map key to Dependency (missing min version check)

  fzanollo

  committed
  d5f6050

Commits on Jul 13, 2021

• Dependency implements operand<

  fzanollo

  committed
  c737c8d

• Dependency.MinVersion type is AppInstaller::Utility::Version

  fzanollo

  committed
  087dd8d

• choose installer using ManifestComparator

  fzanollo

  committed
  46d9d0b

Commits on Jul 14, 2021

• getting composite source

  fzanollo

  committed
  c82f234

• Drop const from the returned type of GetSource

  JohnMcPMS

  committed
  aebac6b

• add check for min version

  fzanollo

  committed
  3bac9ab

• Merge branch 'master' into dependencyGraph

  fzanollo

  committed
  0e1fc7f

• Merge remote-tracking branch 'john/dropconst' into dependencyGraph

  fzanollo

  committed
  3ebfb65

Commits on Jul 15, 2021

• spelling

  fzanollo

  committed
  da52d81

• add dependencies source

  fzanollo

  committed
  0a8f069

• new parameter dependency source, open source can set up both: source and dependency source

  fzanollo

  committed
  d70c55d

• spelling

  fzanollo

  committed
  2e6f29f

Commits on Jul 16, 2021

• DependencyGraph struct, manages only node/adjacent addition, loop check

  fzanollo

  committed
  9d39e48

• OpenSource() missing

  fzanollo

  committed
  00489c6

• add adjacents to spellchecker

  fzanollo

  committed
  572c2bf

Commits on Jul 19, 2021

• graph logic is ok, installer selection and test source settings needs to be fixed

  fzanollo

  committed
  70978ee

• dependency-source argument

  fzanollo

  committed
  743ca96

• typo

  fzanollo

  committed
  edde7c0

Commits on Jul 21, 2021

• DependencyGraph receives function to search for dependencies, auto-builds the graph

  fzanollo

  committed
  25f30de

Commits on Jul 22, 2021

• dependency table, create with id

  fzanollo

  committed
  ef3e6a0

Commits on Jul 23, 2021

• dependency graph logic moved to manifest common

  fzanollo

  committed
  e371668

Commits on Jul 26, 2021

• refactor

  fzanollo

  committed
  e6c00d6

Commits on Jul 27, 2021

• break InstallMultiple workflow into two

  fzanollo

  committed
  7b4238a

Commits on Jul 28, 2021

• SelectInstallerFromMetadata does not receive context

  fzanollo

  committed
  a05f384

• leaving workflow to work as in report dependencies, with the addition of managing package dep

  fzanollo

  committed
  4a1aec8

• move dependencies to context data

  fzanollo

  committed
  29bc5fd

Commits on Jul 29, 2021

• dependency graph + installation, all tests passed

  fzanollo

  committed
  48fbb52

• information detail, delete temp folder

  fzanollo

  committed
  43099ed

Commits on Aug 3, 2021

• merge with master

  fzanollo

  committed
  8eede60

• Merge branch 'showDependenciesFeature' into dependencyGraph

  fzanollo

  committed
  70cc93e

Commits on Aug 5, 2021

• more testing for dependencies on install command

  fzanollo

  committed
  40abbda

Commits on Aug 6, 2021

• valid min version test

  fzanollo

  committed
  e8b4e6a

• typo

  fzanollo

  committed
  cadeaa8

• Merge branch 'master' into showDependenciesFeature

  fzanollo

  committed
  eb91317

• Merge branch 'showDependenciesFeature' into dependencyGraph

  fzanollo

  committed
  622d39c

Commits on Sep 30, 2021

• Merged from master

  

  Akinwale Alagbe

  committed
  d67fabd

Commits on Oct 1, 2021

• temp stash

  

  Akinwale Alagbe

  committed
  d9f41c8

• temp stash

  

  Akinwale Alagbe

  committed
  1bd88aa

• Fixed merge errors

  

  Akinwale Alagbe

  committed
  609f791

Commits on Oct 5, 2021

• Merge branch 'master' of https://github.com/hackean-msft/winget-cli into user/akalagbe/floppy-dependency-graph

  

  Akinwale Alagbe

  committed
  fddc0ae

• Merge branch 'master' of https://github.com/microsoft/winget-cli into user/flopyy/dependencyGraph

  

  Akinwale Alagbe

  committed
  ed7e390

• More cleanup

  

  Akinwale Alagbe

  committed
  87b9e10

Commits on Oct 11, 2021

• temp stash

  

  Akinwale Alagbe

  committed
  bfa6358

• Removed prompt for failed dependencies

  

  Akinwale Alagbe

  committed
  4f67502

• Removed declarations for dependencies table

  

  Akinwale Alagbe

  committed
  bfd8c47

• Spell check fix

  

  Akinwale Alagbe

  committed
  a24cff0

• Merged and fixed merge conflicts

  

  Akinwale Alagbe

  committed
  851bda6

Commits on Oct 12, 2021

• dependency implementation v1

  

  Akinwale Alagbe

  committed
  9e9b32d

Commits on Oct 13, 2021

• In case of fire, push

  

  Akinwale Alagbe

  committed
  5f6c435

Commits on Oct 14, 2021

• Merge branch 'master' of https://github.com/microsoft/winget-cli into dependencyGraph

  

  Akinwale Alagbe

  committed
  68e9c53

Commits on Oct 16, 2021

• WingetUtil changes done checkpoint1

  

  Akinwale Alagbe

  committed
  632e01f

• Fixed spellcheck error

  

  Akinwale Alagbe

  committed
  ea5dc4f

• Merge branch 'master' of https://github.com/microsoft/winget-cli into dependencyGraph

  

  Akinwale Alagbe

  committed
  212ffa6

Commits on Oct 19, 2021

• Addressed pr comments.

  

  Akinwale Alagbe

  committed
  4d4af06

• Addressed PR comments 2

  

  Akinwale Alagbe

  committed
  681d88c

Commits on Oct 20, 2021

• Code cleanup

  

  Akinwale Alagbe

  committed
  1210a5f

• Merge branch 'master' into dependencyGraph

  hackean-msft

  authored
  5b6a4fb

• Fixed spell check error

  

  Akinwale Alagbe

  committed
  e2e5f61

• Merge branch 'dependencyGraph' of https://github.com/fzanollo/winget-cli into dependencyGraph

  

  Akinwale Alagbe

  committed
  ee9ea0b

• Merge branch 'master' of https://github.com/microsoft/winget-cli into dependencyGraph

  

  Akinwale Alagbe

  committed
  160c4c6

Commits on Oct 22, 2021

• Refactored DependencyGraph

  

  Akinwale Alagbe

  committed
  ad46ffe

Commits on Oct 23, 2021

• Fixed typos

  

  Akinwale Alagbe

  committed
  2a247bd

• Merge branch 'dependencyGraph' of https://github.com/fzanollo/winget-cli into user/akalagbe/dependecies-index-creation

  

  Akinwale Alagbe

  committed
  adf17ba

• Merge branch 'master' of https://github.com/microsoft/winget-cli into user/akalagbe/dependecies-index-creation

  

  Akinwale Alagbe

  committed
  6e70a75

• Fixed typo

  

  Akinwale Alagbe

  committed
  520beaf

• Code refactor and typo fix

  

  Akinwale Alagbe

  committed
  b5788b9

Commits on Oct 24, 2021

• Merge branch 'dependencyGraph' of https://github.com/fzanollo/winget-cli into user/akalagbe/dependecies-index-creation

  

  Akinwale Alagbe

  committed
  c5f7c7d

Commits on Oct 25, 2021

• throw exception when package is dependency

  

  Akinwale Alagbe

  committed
  cf4fdbb

Commits on Oct 26, 2021

• Bug fix

  

  Akinwale Alagbe

  committed
  f700655

• Fixed typo

  

  Akinwale Alagbe

  committed
  cf6cc39

Commits on Nov 2, 2021

• pulled and fixed merge conflicts

  

  Akinwale Alagbe

  committed
  5632e8f

• Error messages

  

  Akinwale Alagbe

  committed
  97e833b

• Replaced file path for pointer for manifest validation.

  

  Akinwale Alagbe

  committed
  26cf6b2

• Fixed bug

  

  Akinwale Alagbe

  committed
  99b8d38

• Fixed spellcheck error

  

  Akinwale Alagbe

  committed
  4ad198e

• MultiManifestPackageHasDependencies error message

  

  Akinwale Alagbe

  committed
  0d38185

• Code refactor

  

  Akinwale Alagbe

  committed
  25fd69d

Commits on Nov 8, 2021

• Moved to 1.4 schema

  

  Akinwale Alagbe

  committed
  316b526

• Moved to schema 1.4

  

  Akinwale Alagbe

  committed
  8532794

• Merge branch 'master' of https://github.com/microsoft/winget-cli into user/akalagbe/dependencies-index-creation

  

  Akinwale Alagbe

  committed
  e04433a

• Moved dependencies validation from index

  

  Akinwale Alagbe

  committed
  adae9d8

• Moved validation out of index

  

  Akinwale Alagbe

  committed
  849ef91

• Adding error for missing package ids

  

  Akinwale Alagbe

  committed
  31caabf

• throw when manifest id not found when adding dependencies

  

  Akinwale Alagbe

  committed
  8b0b261

Commits on Nov 11, 2021

• Addressed PR comments

  

  Akinwale Alagbe

  committed
  050ebf4

• Removed duplicate interface file

  

  Akinwale Alagbe

  committed
  8746c1d

• Code cleanup

  

  Akinwale Alagbe

  committed
  07359f3

• Using single api for addition and deletion operation

  

  Akinwale Alagbe

  committed
  5dc5c5e

Commits on Nov 13, 2021

• Moved validation out of dependencies table

  

  Akinwale Alagbe

  committed
  a7d8e33

• Merge branch 'master' of https://github.com/microsoft/winget-cli into user/akalagbe/dependencies-index-creation

  

  Akinwale Alagbe

  committed
  1969b77

• Fixed spell check errors

  

  Akinwale Alagbe

  committed
  c2e1c44

Commits on Nov 14, 2021

• Code refactor

  

  Akinwale Alagbe

  committed
  cdcf839

Commits on Nov 15, 2021

• update flag value

  

  Akinwale Alagbe

  committed
  62e5c54

Commits on Nov 17, 2021

• Merge branch 'master' of https://github.com/microsoft/winget-cli into user/akalagbe/dependencies-index-creation

  

  Akinwale Alagbe

  committed
  cc56df9

• Created a new enum for validation manifest dependencies option

  

  Akinwale Alagbe

  committed
  dd7c4b3

Commits on Nov 18, 2021

• Code refactor

  

  Akinwale Alagbe

  committed
  e043e0d

• create dependencies save point fix.

  

  Akinwale Alagbe

  committed
  5449de6

• Refactored Insert Depedencies function

  

  Akinwale Alagbe

  committed
  2dad0a6

• cleanup

  

  Akinwale Alagbe

  committed
  c043426

• more cleanup

  

  Akinwale Alagbe

  committed
  cab0dbc

• return set from get dependencies

  

  Akinwale Alagbe

  committed
  77ee5da

Commits on Nov 19, 2021

• Addressed PR comments

  

  Akinwale Alagbe

  committed
  284e434

• Merge branch 'master' of https://github.com/microsoft/winget-cli into user/akalagbe/dependencies-index-creation

  

  Akinwale Alagbe

  committed
  c1ac266

• Addressed PR comments

  

  Akinwale Alagbe

  committed
  44529e7

• Tabs vs spaces

  

  Akinwale Alagbe

  committed
  1d812bd

Commits on Nov 29, 2021

• Merge branch 'master' of https://github.com/microsoft/winget-cli into user/akalagbe/dependencies-index-creation

  

  Akinwale Alagbe

  committed
  c503e3a

• Addressed PR comments

  

  Akinwale Alagbe

  committed
  66b8d14

Commits on Nov 30, 2021

• More tests

  

  Akinwale Alagbe

  committed
  cff9dc1

• Code refactor

  

  Akinwale Alagbe

  committed
  4d1a974

• Addressed PR comments

  

  Akinwale Alagbe

  committed
  5b2c0ea

Commits on Dec 1, 2021

• Merge branch 'master' of https://github.com/microsoft/winget-cli into user/akalagbe/dependencies-index-creation

  

  Akinwale Alagbe

  committed
  f49a2e2

• Using initializer list in place of vector

  

  Akinwale Alagbe

  committed
  8a69efc

• Fixed bugs

  

  Akinwale Alagbe

  committed
  6b8d404

• Code refactor

  

  Akinwale Alagbe

  committed
  2131764

Commits on Dec 2, 2021

• Implemented not needed check for min version in dependencies table

  

  Akinwale Alagbe

  committed
  73f5f68

Commits on Dec 3, 2021

• Delete versions if there are not referenced

  

  Akinwale Alagbe

  committed
  8423300

• Fixed spellcheck error

  

  Akinwale Alagbe

  committed
  beae35a