-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Package Dependencies to index. #1667
Add Package Dependencies to index. #1667
Conversation
…dencyList; add Dependency to context data
…es task divided, creates ValidateFlow
…DependencyList.dependencies private, code style
Co-authored-by: JohnMcPMS <[email protected]>
…encies is now a WorkflowTask receiving resource string id
…w, move dependency related function to DependenciesFlow
… user/akalagbe/dependencies-index-creation
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentactivatable Globals mytoolTo accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the [email protected]:hackean-msft/winget-cli.git repository
|
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentactivatable Globals mytoolTo accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the [email protected]:hackean-msft/winget-cli.git repository
|
src/AppInstallerRepositoryCore/Microsoft/Schema/1_4/DependenciesTable.cpp
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/1_4/DependenciesTable.cpp
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/1_4/Interface_1_4.cpp
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/1_3/Interface_1_3.cpp
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/1_4/DependenciesTable.cpp
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/1_4/DependenciesTable.cpp
Outdated
Show resolved
Hide resolved
… user/akalagbe/dependencies-index-creation
src/AppInstallerRepositoryCore/Microsoft/Schema/1_4/DependenciesTable.cpp
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/1_0/ManifestTable.h
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/1_0/Interface_1_0.cpp
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/1_4/Interface_1_4.cpp
Outdated
Show resolved
Hide resolved
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentactivatable Archs Globals mytoolTo accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the [email protected]:hackean-msft/winget-cli.git repository
|
{ | ||
THROW_HR(APPINSTALLER_CLI_ERROR_INVALID_TABLE_COLUMN); | ||
builder.Select(SQLite::RowIDName).From(s_DependenciesTable_Table_Name).Where(column).Equals(Unbound).Limit(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: You can pass valueRowId
instead of Unbound
to achieve the same thing here. Not need to change it, just a note in case you weren't aware.
This pull request creates a new dependencies table in the index an provides an interface via winget util to allow the addition, update and validation of manifest dependencies to the index.
A new API is exposed to allow the verification of the dependency graph structure when a delete operation is performed for a specific manifest.
Microsoft Reviewers: Open in CodeFlow