Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable default compile items for Microsoft.TestPlatform.PlatformAbstractions #2556

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Enable default compile items for Microsoft.TestPlatform.PlatformAbstractions #2556

merged 1 commit into from
Sep 3, 2020

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Sep 1, 2020

This change allows all files to show in Solution Explorer, with the content conditionally included according to well-known compile-time definitions.

@nohwnd nohwnd self-assigned this Sep 2, 2020
@nohwnd
Copy link
Member

nohwnd commented Sep 2, 2020

I always wondered why they did it this way, instead of the way you propose in this PR. But it never got high enough on my todo list, because it works. Will merge this in few days once we finalize some other changes. Thank you!

@Haplois
Copy link
Contributor

Haplois commented Sep 2, 2020

I already did most of this work for my work on adding support for netstandard1.0 to our primitives. @nohwnd, please don't merge until I compare it with mine.

@nohwnd nohwnd assigned Haplois and unassigned nohwnd Sep 2, 2020
@nohwnd
Copy link
Member

nohwnd commented Sep 2, 2020

@Haplois it's yours now. @sharwell needs this merged for #2554, but let's merge tomorrow at earliest.

Haplois
Haplois suggested changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@Haplois Haplois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am doing some tests, will merge soon.

@Haplois Haplois merged commit 60d87bb into microsoft:master Sep 3, 2020
@sharwell sharwell deleted the all-files branch September 3, 2020 16:43
This was referenced Mar 6, 2021
Merged
Merged
Merged
Merged
Merged
Closed
Closed
This was referenced Mar 13, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Open
mburumaxwell pushed a commit to faluapp/falu-dotnet that referenced this pull request Jun 12, 2021
Merged PR 2429: Bump Microsoft.NET.Test.Sdk from 16.8.3 to 16.9.1
a20ca74 
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1.

#Release notes

*Sourced from [Microsoft.NET.Test.Sdk's releases](https://github.com/microsoft/vstest/releases).*

> ## v16.9.1
> See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1691).
>
> ## v16.9.0-preview-20210127-04
> See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1690-preview-20210127-04).
>
> ## v16.9.0-preview-20210106-01
> See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1690-preview-20210106-01).
>
> ## v16.9.0-preview-20201123-03
> See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1690-preview-20201123-03).
>
> -------------------------------
>
> ## v16.9.0-preview-20201020-06
> See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1690-preview-20201020-06).
>
> -------------------------------
>
> ## 16.9.0-preview-20201020-06
>
> ### Issue Fixed
> * Enable Fakes Datacollector settings to be added in design mode [#2586](microsoft/vstest#2586)
> * Fix blame parameter, warning, and add all testhosts to be ngend [#2579](microsoft/vstest#2579)
> * Add netcoreapp1.0 support to `Microsoft.TestPlatform.TestHost` NuGet [#2569](microsoft/vstest#2569)
> * Use bitness from process or OS [#2571](microsoft/vstest#2571)
> * Restore netcoreapp1.0 support for testhost [#2554](microsoft/vstest#2554)
> * Get symbols of DiaSymReader from externals [#2560](microsoft/vstest#2560)
> * Do not force .NET4.5 in case legacy test settings are provided [#2545](microsoft/vstest#2545)
> * Simplify package references [#2559](microsoft/vstest#2559)
> * Enable default compile items for Microsoft.TestPlatform.PlatformAbstractions [#2556](microsoft/vstest#2556)
> * Avoid logging >Task returned false but did not log an error.< [#2557](microsoft/vstest#2557)
> * Fixed code coverage compatibility issue [#2527](microsoft/vstest#2527)
> * Add environment variables to enable MacOS dump
> * Adding test run attachments processing [#2463](microsoft/vstest#2463)
>
> See full log [here](microsoft/vstest@v16.8.0-release-20200921-02...v16.9.0-preview-20201020-06)
>
> ### Drops
>
> * TestPlatform vsix: [16.9.0-preview-20201020-06](https://vsdrop.corp.microsoft.com/file/v1/Products/DevDiv/microsoft/vstest/master/20201020-06;/TestPlatform.vsix)
> * Microsoft.TestPlatform.ObjectModel : [16.9.0-preview-20201020-06](https://www.nuget.org/packages/Microsoft.TestPlatform.ObjectModel/16.9.0-preview-20201020-06)

...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haplois Haplois Haplois approved these changes

Assignees

@Haplois Haplois

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharwell @nohwnd @Haplois