Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build - set no-sandbox everywhere #81096

Merged
merged 1 commit into from
Sep 18, 2019
Merged

build - set no-sandbox everywhere #81096

merged 1 commit into from
Sep 18, 2019

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Sep 18, 2019

No description provided.

@bpasero bpasero added this to the September 2019 milestone Sep 18, 2019
@bpasero bpasero self-assigned this Sep 18, 2019
@bpasero
Copy link
Member Author

bpasero commented Sep 18, 2019

The intent is to always have --no-sandbox as argument on Linux to prevent issues such as #81056

@joaomoreno @Tyriar please let me know if you can think of yet another place where we need to set this. I feel we have the following entry points:

  • from the command line ("code"): should be handled via the change in cli.ts
  • from the window manager: hopefully covered by the changes to the .desktop files
  • from invoking the executable directly: as far as I can tell we cannot do anything about that usage

NOTE: issue does not appear when running Electron as node!

Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants