allow user disable electron's sandbox #22
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why user need to disable electron's sandbox :
jest
/jest-electron
as root. without--no-sandbox
option forelectron
, test cases will fail silently becausejest-electron
failed to spawn anelectron
processsecurity impact:
malicious javascript codes running within electron's renderer process are not sandboxed anymore and have the ability to harm the system. but here in
jest
test cases are trusted codes, so i think security impact is trivial.who disables electron's sandbox on non-windows platform by default:
1, vscode. see microsoft/vscode#81096
2, cypress. see cypress-io/cypress#5458
fixes #19