Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #71688 #71689

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Fixes #71688 #71689

merged 1 commit into from
Apr 3, 2019

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Apr 3, 2019 •
edited
Loading

Invert conditional on restoring webviews without serializer. We only want to restore webviews that:

  • have a serializer registered
  • Or were previously serialized (and thus are instances of RevivedWebviewEditorInput )

@mjbvz mjbvz self-assigned this Apr 3, 2019
rebornix
rebornix approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm seeing the same issue when reloading the window after opening a PR description view and this fix solved it. Thanks.

@mjbvz mjbvz merged commit 0dd516d into microsoft:release/1.33 Apr 3, 2019
@mjbvz mjbvz added this to the March 2019 milestone Apr 3, 2019
@mjbvz mjbvz mentioned this pull request Apr 3, 2019
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rebornix rebornix rebornix approved these changes

Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
March 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@mjbvz @rebornix