Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpersisted webviews being kept around when editor restarts #71688

Closed
mjbvz opened this issue Apr 3, 2019 · 3 comments
Closed

Unpersisted webviews being kept around when editor restarts #71688

mjbvz opened this issue Apr 3, 2019 · 3 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release important Issue identified as high-priority verified Verification succeeded webview Webview issues
Milestone
March 2019

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 3, 2019 •
edited
Loading

Issue Type: Bug

Steps

  1. Run Show release notes
  2. Reload window

Bug
Empty release notes tab still around after start

VS Code version: Code - Insiders 1.33.0-insider (4d1cb56, 2019-04-03T08:11:05.447Z)
OS version: Darwin x64 18.2.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 3, 3
Memory (System) 16.00GB (0.63GB free)
Process Argv -psn_0_19132990
Screen Reader no
VM 22%
@mjbvz mjbvz added important Issue identified as high-priority candidate Issue identified as probable candidate for fixing in the next release webview Webview issues labels Apr 3, 2019
@mjbvz mjbvz added this to the March 2019 milestone Apr 3, 2019
@mjbvz mjbvz self-assigned this Apr 3, 2019
@mjbvz
Copy link
Collaborator Author

mjbvz commented Apr 3, 2019

Fixed by 06dd68b in master

@mjbvz mjbvz closed this as completed Apr 3, 2019
@mjbvz mjbvz reopened this Apr 3, 2019
mjbvz added a commit to mjbvz/vscode that referenced this issue Apr 3, 2019
@mjbvz
Fixes microsoft#71688
4bd9301
@rebornix
Copy link
Member

rebornix commented Apr 3, 2019

Another way to verify:

  • Open a description view for a pull request from GH PR extension
  • Reload the window

mjbvz added a commit that referenced this issue Apr 3, 2019
@mjbvz
Merge pull request #71689 from mjbvz/fix-71688
0dd516d 
Fixes #71688
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Apr 3, 2019
@mjbvz
Copy link
Collaborator Author

mjbvz commented Apr 3, 2019

Fixed in 1.33 branch with #71689

@mjbvz mjbvz closed this as completed Apr 3, 2019
@roblourens roblourens added the verified Verification succeeded label Apr 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators May 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release important Issue identified as high-priority verified Verification succeeded webview Webview issues
Projects
None yet
Milestone
March 2019
Development

No branches or pull requests
3 participants
@roblourens @rebornix @mjbvz