extract IconPath type for uri, uris, and ThemeIcon combo
#232471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
commented
Oct 29, 2024
| * Represents an icon in the UI. This is either an uri, separate uris for the light- and dark-themes, | ||
| * or a {@link ThemeIcon theme icon}. | ||
| */ | ||
| export type IconPath = Uri | { |
There was a problem hiding this comment.
@mjbvz Let me know if you have an idea for a better name. This isn't overly correct but matches the property names.
Also there are still a few places where iconPath: ... is used/defined but where not this exact shape is supported
mjbvz
approved these changes
Oct 29, 2024
eamodio
reviewed
Oct 30, 2024
| */ | ||
| dark: string | Uri; | ||
| } | ThemeIcon; | ||
| iconPath?: IconPath; |
There was a problem hiding this comment.
@jrieken since this type took a string, in addition to a Uri, isn't this a breaking change?
There was a problem hiding this comment.
Yeah, sorry. That was an oversight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #124363