Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align iconPath-API #124363

Open
jrieken opened this issue May 21, 2021 · 9 comments
Open

Align iconPath-API #124363

jrieken opened this issue May 21, 2021 · 9 comments
Assignees
Labels
api debt Code quality issues
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented May 21, 2021

We have various definitions for iconPath properties and they all have different type signatures (no support ThemeIcon, no support for light/dark). We should always use the same OR-type sausage, ideally: Uri | { light: Uri; dark: Uri } | ThemeIcon.


@jrieken jrieken added api debt Code quality issues labels May 21, 2021
@jrieken
Copy link
Member Author

jrieken commented May 21, 2021

This also needs support from the actual feature area owners

@mjbvz
Copy link
Collaborator

mjbvz commented May 21, 2021

#90616 Tracks enabling themeIcons in webviews

@eamodio
Copy link
Contributor

eamodio commented Jul 8, 2021

@eamodio
Copy link
Contributor

eamodio commented Jul 8, 2021

#128258 tracks SCM decoration ThemeIcon support

@eamodio

This comment has been minimized.

@jrieken

This comment has been minimized.

@mjbvz mjbvz added this to the Backlog milestone Oct 22, 2021
@joaomoreno joaomoreno removed their assignment Nov 8, 2021
@rebornix rebornix assigned alexr00 and unassigned rebornix Dec 8, 2022
@alexr00
Copy link
Member

alexr00 commented Dec 9, 2022

CommentAuthorInformation#iconPath

I think there's an argument that we leave this one as only Uri. This is intended to be a representation of a user. It would be odd if this were a codicon.

@jrieken
Copy link
Member Author

jrieken commented Dec 9, 2022

Well, could be the default icon in case no custom user icon exists?

@jrieken
Copy link
Member Author

jrieken commented Oct 29, 2024

We have extracted IconPath but there are still a few places where we use slightly different iconPath shapes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api debt Code quality issues
Projects
None yet
Development

No branches or pull requests

6 participants