-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align iconPath-API #124363
Comments
This also needs support from the actual feature area owners |
#90616 Tracks enabling themeIcons in webviews |
@jrieken should we add decorations to this too? |
#128258 tracks SCM decoration ThemeIcon support |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I think there's an argument that we leave this one as only |
Well, could be the default icon in case no custom user icon exists? |
We have extracted |
We have various definitions for
iconPath
properties and they all have different type signatures (no support ThemeIcon, no support for light/dark). We should always use the same OR-type sausage, ideally:Uri | { light: Uri; dark: Uri } | ThemeIcon
.The text was updated successfully, but these errors were encountered: