Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools API tweaks #232023

Merged
merged 8 commits into from
Oct 23, 2024
Merged

tools API tweaks #232023

merged 8 commits into from
Oct 23, 2024

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Oct 23, 2024 •
edited
Loading

This is for #231925 and #231937 (and also #231938)

For #231937 I have change the token type to be never instead of unknown. This makes it harder to use a wrong type because most things (except for never) cause a compile error and it might help to clarify this

@jrieken jrieken requested a review from mjbvz as a code owner October 23, 2024 09:05
@jrieken jrieken self-assigned this Oct 23, 2024
@jrieken jrieken enabled auto-merge (squash) October 23, 2024 09:05
@vs-code-engineering vs-code-engineering bot added this to the October 2024 milestone Oct 23, 2024
TylerLeonhardt
TylerLeonhardt previously approved these changes Oct 23, 2024
View reviewed changes
@jrieken jrieken merged commit 86a4d1d into main Oct 23, 2024
8 checks passed
@jrieken jrieken deleted the joh/principal-silkworm branch October 23, 2024 23:25
@roblourens roblourens mentioned this pull request Oct 25, 2024
Closed
roblourens added a commit that referenced this pull request Oct 25, 2024
@roblourens
Remove backcompat workaround
3cb8ebb 
From #232023
Fix #232301
@roblourens roblourens mentioned this pull request Oct 25, 2024
Merged
rzhao271 pushed a commit that referenced this pull request Oct 25, 2024
@roblourens
Remove backcompat workaround (#232302)
38dc6ac 
From #232023
Fix #232301
roblourens added a commit that referenced this pull request Oct 28, 2024
@roblourens
Remove backcompat workaround (#232302)
718ff45 
From #232023
Fix #232301
@roblourens roblourens mentioned this pull request Oct 28, 2024
Merged
roblourens added a commit that referenced this pull request Oct 28, 2024
@roblourens
Remove backcompat workaround (#232429)
c1b45ed 
Remove backcompat workaround (#232302)

From #232023
Fix #232301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjbvz mjbvz mjbvz approved these changes

@connor4312 connor4312 connor4312 approved these changes

@roblourens roblourens roblourens approved these changes

@TylerLeonhardt TylerLeonhardt TylerLeonhardt left review comments

Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
October 2024
Development

Successfully merging this pull request may close these issues.
5 participants
@jrieken @roblourens @connor4312 @TylerLeonhardt @mjbvz