Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctor order in LanguageModelToolCallPart #231925

Closed
jrieken opened this issue Oct 22, 2024 · 0 comments
Closed

Ctor order in LanguageModelToolCallPart #231925

jrieken opened this issue Oct 22, 2024 · 0 comments
Assignees
Labels
api bug Issue identified by VS Code Team member as probable bug chat insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Oct 22, 2024

It should callId, name, parameters and not name, callId, parameter

vscode/src/vscode-dts/vscode.d.ts

Lines 19802 to 19822 in c50ff3b

export class LanguageModelToolCallPart {
/**
* The name of the tool to call.
*/
name: string;
/**
* The ID of the tool call. This is a unique identifier for the tool call within the chat request.
*/
callId: string;
/**
* The parameters with which to call the tool.
*/
parameters: object;
/**
* Create a new LanguageModelToolCallPart.
*/
constructor(name: string, callId: string, parameters: object);
}

@jrieken jrieken added this to the October 2024 milestone Oct 22, 2024
@jrieken jrieken added api chat bug Issue identified by VS Code Team member as probable bug labels Oct 22, 2024
jrieken added a commit that referenced this issue Oct 23, 2024
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Oct 23, 2024
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 24, 2024
@eleanorjboyd eleanorjboyd added the verified Verification succeeded label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api bug Issue identified by VS Code Team member as probable bug chat insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants