Re #209154. Make execution count sticky. #224905
Merged
+68
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the execution count sticky, in this PR we manually adjust the top of the execution count label element on notebook scroll.
sticky.execution.count.mov
The main challenge here is it flickers when the notebook sticky scroll disappears as it will trigger layouts in two different animation frames: the sticky scroll element disappears in current frame and the notebook list view layouts in next frame, this leads to a misalignment of the execution count label briefly, which is visually annoying.
Thus in this PR we try to do these two layouts at the same time.