Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re #209154. Make execution count sticky. #224905

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

rebornix
Copy link
Member

@rebornix rebornix commented Aug 6, 2024

To make the execution count sticky, in this PR we manually adjust the top of the execution count label element on notebook scroll.

sticky.execution.count.mov

The main challenge here is it flickers when the notebook sticky scroll disappears as it will trigger layouts in two different animation frames: the sticky scroll element disappears in current frame and the notebook list view layouts in next frame, this leads to a misalignment of the execution count label briefly, which is visually annoying.

Thus in this PR we try to do these two layouts at the same time.

@rebornix rebornix self-assigned this Aug 6, 2024
@rebornix rebornix enabled auto-merge (squash) August 6, 2024 04:04
@rebornix rebornix requested a review from Yoyokrazy August 6, 2024 04:04
@vs-code-engineering vs-code-engineering bot added this to the August 2024 milestone Aug 6, 2024
@rebornix rebornix merged commit 6288e5d into main Aug 6, 2024
6 checks passed
@rebornix rebornix deleted the rebornix/doubtful-carp branch August 6, 2024 16:38
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants